geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Jencks <da...@coredevelopers.net>
Subject Re: cvs commit: incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/kernel Kernel.java
Date Wed, 10 Mar 2004 17:10:46 GMT
Thanks for the info.

As far as I can tell this constructor is not used (not called directly  
in code and doesn't seem to break any tests).  There is definitely  
something wrong with it before my change: whether a more appropriate  
change would be

public Kernel(String kernelName) {
    this(kernelName, null);
}

I can't say and hope Jeremy and/or Dain will comment on.

thanks
david jencks

On Wednesday, March 10, 2004, at 08:00 AM, Jacek Laskowski wrote:

> djencks@apache.org wrote:
>> djencks     2004/03/09 09:58:49
>>   Modified:    modules/kernel/src/java/org/apache/geronimo/kernel
>>                         Kernel.java
>>   Log:
>>   fix apparent typo
>>     Revision  Changes    Path
>>   1.21      +2 -2       
>> incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/ 
>> kernel/Kernel.java
>>     Index: Kernel.java
>>   ===================================================================
>>   RCS file:  
>> /home/cvs/incubator-geronimo/modules/kernel/src/java/org/apache/ 
>> geronimo/kernel/Kernel.java,v
>>   retrieving revision 1.20
>>   retrieving revision 1.21
>>   diff -u -r1.20 -r1.21
>>   --- Kernel.java	25 Feb 2004 09:57:49 -0000	1.20
>>   +++ Kernel.java	9 Mar 2004 17:58:49 -0000	1.21
>>   @@ -106,7 +106,7 @@
>>         * @param domainName the domain name to be used for the JMX  
>> MBeanServer
>>         */
>>        public Kernel(String domainName) {
>>   -        this(domainName, null);
>>   +        this(null, domainName);
>>        }
>
> Hey Dave,
>
> While I was working on KernelTest (that's not yet committed) I talked  
> about it to Dain and it's said it's not a typo. It was something about  
> how the kernelName and domainName are maintained or so. I don't  
> remember the details, but was warned not to introduce the change  
> unless Jeremy said it's ok.
>
> I rose it up just in case it might have missed others' attention.
>
> Cheers,
> Jacek
>


Mime
View raw message