geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacek Laskowski <jacek.laskow...@hp.com>
Subject Re: cvs commit: incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean InvalidConfigurationException.java
Date Thu, 05 Feb 2004 22:02:42 GMT
jboynes@apache.org wrote:
> jboynes     2004/02/05 11:25:18
> 
>   Modified:    modules/kernel/src/java/org/apache/geronimo/gbean
>                         InvalidConfigurationException.java
>   Log:
>   Make unchecked as in many cases this is used where the user knows the GBeanInfo is
valid.
>   
>   Revision  Changes    Path
>   1.2       +5 -3      incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/InvalidConfigurationException.java
>   
>   Index: InvalidConfigurationException.java
>   ===================================================================
>   RCS file: /home/cvs/incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/InvalidConfigurationException.java,v
>   retrieving revision 1.1
>   retrieving revision 1.2
>   diff -u -r1.1 -r1.2
>   --- InvalidConfigurationException.java	12 Jan 2004 01:38:55 -0000	1.1
>   +++ InvalidConfigurationException.java	5 Feb 2004 19:25:18 -0000	1.2
>   @@ -56,11 +56,13 @@
>    package org.apache.geronimo.gbean;
>    
>    /**
>   - *
>   + * Unchecked Exception indicating that the GBeanInfo is invalid.
>   + * This is unchecked becuase in many circumstances the GBeanInfo

There's a typo - becuase -> because.

>   + * is set up in a static initializer and should always be valid.

Shouldn't 'should' be changed to 'must' as GBeanInfo must be valid 
otherwise the exception is thrown.

>     *
>     * @version $Revision$ $Date$
>     */
>   -public class InvalidConfigurationException extends Exception {
>   +public class InvalidConfigurationException extends RuntimeException {
>        public InvalidConfigurationException() {
>        }

Jacek

Mime
View raw message