Mailing-List: contact geronimo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: geronimo-dev@incubator.apache.org
Message-ID: <3FDC83E3.9030200@hp.com>
Date: Sun, 14 Dec 2003 16:38:11 +0100
From: Jacek Laskowski <jacek.laskowski@hp.com>
Organization: HP Consulting & Integration, Poland
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.0.0) Gecko/20020530
MIME-Version: 1.0
To: geronimo-dev@incubator.apache.org
Subject: Renaming methods in o.a.g.kernel.deployment.AbstractDeploymentPlanner
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

I wonder why are the methods of 
o.a.g.kernel.deployment.AbstractDeploymentPlanner:

     protected abstract boolean addURL(DeployURL deployURL, Set goals, 
Set plans) throws DeploymentException;

     protected abstract boolean redeployURL(RedeployURL redeployURL, Set 
goals) throws DeploymentException;

     protected abstract boolean removeURL(UndeployURL undeployURL, Set 
goals, Set plans) throws DeploymentException;

named this way?

Wouldn't it be better off with the names changed to:

     protected abstract boolean deployURL(DeployURL deployURL, Set 
goals, Set plans) throws DeploymentException;

     protected abstract boolean redeployURL(RedeployURL redeployURL, Set 
goals) throws DeploymentException;

     protected abstract boolean undeployURL(UndeployURL undeployURL, Set 
goals, Set plans) throws DeploymentException;

The names would then be more consistent with the names of the first 
input parameter (actually redeployURL is so). Also, they would be more 
meaningful (at least to me :-))

The first time I saw addURL I thought it'd add a URL to the list of 
deployments to deploy, but quickly realized that it did even more, it 
added the URL to the list of deployments by deploying it.

Jacek