From geronimo-dev-return-5360-apmail-incubator-geronimo-dev-archive=incubator.apache.org@incubator.apache.org Tue Dec 02 21:38:56 2003 Return-Path: Delivered-To: apmail-incubator-geronimo-dev-archive@www.apache.org Received: (qmail 2121 invoked from network); 2 Dec 2003 21:38:56 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 2 Dec 2003 21:38:56 -0000 Received: (qmail 38200 invoked by uid 500); 2 Dec 2003 21:38:36 -0000 Delivered-To: apmail-incubator-geronimo-dev-archive@incubator.apache.org Received: (qmail 38139 invoked by uid 500); 2 Dec 2003 21:38:36 -0000 Mailing-List: contact geronimo-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: geronimo-dev@incubator.apache.org Delivered-To: mailing list geronimo-dev@incubator.apache.org Received: (qmail 38120 invoked from network); 2 Dec 2003 21:38:36 -0000 Received: from unknown (HELO hogshead.codehaus.org) (66.216.68.111) by daedalus.apache.org with SMTP; 2 Dec 2003 21:38:36 -0000 Received: from hogshead.codehaus.org (hogshead.codehaus.org [66.216.68.111]) by hogshead.codehaus.org (8.11.6/8.11.6) with ESMTP id hB2Lj2K14343 for ; Tue, 2 Dec 2003 15:45:02 -0600 Message-ID: <16127427.1070401502147.JavaMail.orion@hogshead.codehaus.org> Date: Tue, 2 Dec 2003 15:45:02 -0600 (CST) From: jira@codehaus.org To: geronimo-dev@incubator.apache.org Subject: [jira] Created: (GERONIMO-122) Proposed refactorings for o.a.g.kernel.deployment.goal.* Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Message: A new issue has been created in JIRA. --------------------------------------------------------------------- View the issue: http://jira.codehaus.org/secure/ViewIssue.jspa?key=GERONIMO-122 Here is an overview of the issue: --------------------------------------------------------------------- Key: GERONIMO-122 Summary: Proposed refactorings for o.a.g.kernel.deployment.goal.* Type: Improvement Status: Unassigned Priority: Trivial Original Estimate: Unknown Time Spent: Unknown Remaining: Unknown Project: Apache Geronimo Assignee: Reporter: Ed Letifov Created: Tue, 2 Dec 2003 3:44 PM Updated: Tue, 2 Dec 2003 3:44 PM Description: I am under impression that some classes in o.a.g.kernel.deployment.goal.* can (should?) be refactored just a little to facilitate more reuse between them. IMHO an abstract class would be welcome in the hierarchy to reduce copy paste in the implementation (and also make tests simpler) I have some concerns about UndeployURL and RedeployURL that do not behave in the same way as other two: they do not normalize file-protocol based URLs and seem to accept null values for the arguments in the constructors. Is it in fact how it is supposed to be? --------------------------------------------------------------------- JIRA INFORMATION: This message is automatically generated by JIRA. If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira