geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@codehaus.org
Subject [jira] Commented: (GERONIMO-131) Remove nullification of DD's locations when the standard DD doesn't exist
Date Mon, 15 Dec 2003 08:04:56 GMT
The following comment has been added to this issue:

     Author: David Jencks
    Created: Mon, 15 Dec 2003 2:04 AM
       Body:
Your change doesn't break any unit tests, but I see that I added this code in revision 1.2.
 As I recall I added it because nothing would deploy correctly without it: most deployers
were relying on j2eeUrl != null to mean the package was for them.  Have you checked that ejb
jars, wars, .sars, and .rars all deploy together correctly with this change?

One simple possibility is to try to get streams from both urls, and set each null individually.
 This should not break any existing usage.  I'd rather see something that doesn't involve
opening streams twice, though.
---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=GERONIMO-131


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: GERONIMO-131
    Summary: Remove nullification of DD's locations when the standard DD doesn't exist
       Type: Improvement

     Status: Open
   Priority: Minor

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: Apache Geronimo
 Components: 
             deployment

   Assignee: David Jencks
   Reporter: Jacek Laskowski

    Created: Sun, 14 Dec 2003 5:03 PM
    Updated: Mon, 15 Dec 2003 2:04 AM

Description:
I spent the whole weekend to eventually find out that Geronimo deploys a deployment unit only
when it contains *two* required files: one that's mandated by the appropriate spec and the
other one - Geronimo-specific. So, when a EJB bean is deployed two files must exist - /META-INF/ejb-jar.xml
and /META-INF/geronimo-ejb-jar.xml, otherwise it won't be deployed at all (and unfortunatelly
no message is printed out about it on the console). What caused me to think about having only
one? Just take a look at org.openejb.nova.deployment.EJBModuleDeploymentPlanner that checks
whether geronimo-ejb-jar.xml exists and also a few lines below is the comment: "currently
everything is in the geronimo-ejb-jar.xml". 

However, o.a.g.kernel.deployment.DeploymentHelper always returns null upon being asked about
standard or geronimo DD when the standard DD is not available (see one of the constructor).
Therefore, DeploymentHelper decides if a module is deployable or not. I think it is not in
charge of giving the answer. The right of answering the question belongs to a planner, thus
the change.

I also change a bit the class's javadoc. 


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message