geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [jira] Closed: (GERONIMO-122) Proposed refactorings for o.a.g.kernel.deployment.goal.*
Date Thu, 11 Dec 2003 12:10:55 GMT

   The following issue has been closed.

   Resolver: Gianny DAMOUR
       Date: Thu, 11 Dec 2003 6:10 AM

Thanks for this patch Ed Letifov.
View the issue:

Here is an overview of the issue:
        Key: GERONIMO-122
    Summary: Proposed refactorings for o.a.g.kernel.deployment.goal.*
       Type: Improvement

     Status: Closed
   Priority: Trivial
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: Apache Geronimo

   Assignee: Gianny DAMOUR
   Reporter: Ed Letifov

    Created: Tue, 2 Dec 2003 3:44 PM
    Updated: Thu, 11 Dec 2003 6:10 AM

I am under impression that some classes in o.a.g.kernel.deployment.goal.* can (should?) be
refactored just a little to facilitate more reuse between them. IMHO an abstract class would
be welcome in the hierarchy to reduce copy paste in the implementation (and also make tests

I have some concerns about UndeployURL and RedeployURL that do not behave in the same way
as other two: they do not normalize file-protocol based URLs and seem to accept null values
for the arguments in the constructors. Is it in fact how it is supposed to be?

This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:

If you want more information on JIRA, or have a bug to report see:

View raw message