geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@codehaus.org
Subject [jira] Commented: (GERONIMO-122) Proposed refactorings for o.a.g.kernel.deployment.goal.*
Date Tue, 02 Dec 2003 21:50:58 GMT
The following comment has been added to this issue:

     Author: Ed Letifov
    Created: Tue, 2 Dec 2003 3:50 PM
       Body:
Clarification: patch1.jar to be unjar-ed in the root project directory, kernel.diff to be
applied in the modules/kernel dir
---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=GERONIMO-122


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: GERONIMO-122
    Summary: Proposed refactorings for o.a.g.kernel.deployment.goal.*
       Type: Improvement

     Status: Unassigned
   Priority: Trivial

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: Apache Geronimo

   Assignee: 
   Reporter: Ed Letifov

    Created: Tue, 2 Dec 2003 3:44 PM
    Updated: Tue, 2 Dec 2003 3:50 PM

Description:
I am under impression that some classes in o.a.g.kernel.deployment.goal.* can (should?) be
refactored just a little to facilitate more reuse between them. IMHO an abstract class would
be welcome in the hierarchy to reduce copy paste in the implementation (and also make tests
simpler) 

I have some concerns about UndeployURL and RedeployURL that do not behave in the same way
as other two: they do not normalize file-protocol based URLs and seem to accept null values
for the arguments in the constructors. Is it in fact how it is supposed to be?



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message