Mailing-List: contact geronimo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: geronimo-dev@incubator.apache.org
Message-ID: <3F8DCCF4.2090502@mortbay.com>
Date: Thu, 16 Oct 2003 08:40:52 +1000
From: Jan Bartel <janb@mortbay.com>
Reply-To: janb@mortbay.com
Organization: Mort Bay Consulting
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
 rv:1.3) Gecko/20030430 Debian/1.3-5
MIME-Version: 1.0
To: geronimo-dev@incubator.apache.org
Subject: Re: Review of refactored deployment classes
References: <Sea1-F1160Gcr85pLBw0000e974@hotmail.com>
In-Reply-To: <Sea1-F1160Gcr85pLBw0000e974@hotmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Hi Gianny,

There was just one other thing I forgot to mention in the last email.

In this call:
List postTasks = getJ2EEModulePlan(dmdMetaData,
                                    dMetaData,
                                    dHelper,
                                    childMBeans);

why do we need 2 types of meta data passed in? Won't just the 
DeploymentMetaData instance suffice?

cheers
Jan
PS
>> + some of the spelling in the comments could do with a bit of a
>>   spell check (only in George Bush's lexicon is "plannification"
>>   a word :-) )
> 
> I agree and shame on me: even in french "plannification" is miss-spelt 
> (only one "n" in french).
:-) L'Acad�mie Fran�aise retirera votre passeport pour des erreurs comme 
cela !