From geronimo-dev-return-4040-apmail-incubator-geronimo-dev-archive=incubator.apache.org@incubator.apache.org Sat Oct 04 23:43:03 2003 Return-Path: Delivered-To: apmail-incubator-geronimo-dev-archive@www.apache.org Received: (qmail 15995 invoked from network); 4 Oct 2003 23:43:02 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 4 Oct 2003 23:43:02 -0000 Received: (qmail 34901 invoked by uid 500); 4 Oct 2003 23:42:40 -0000 Delivered-To: apmail-incubator-geronimo-dev-archive@incubator.apache.org Received: (qmail 34842 invoked by uid 500); 4 Oct 2003 23:42:40 -0000 Mailing-List: contact geronimo-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: geronimo-dev@incubator.apache.org Delivered-To: mailing list geronimo-dev@incubator.apache.org Received: (qmail 34826 invoked from network); 4 Oct 2003 23:42:39 -0000 Received: from unknown (HELO main.gmane.org) (80.91.224.249) by daedalus.apache.org with SMTP; 4 Oct 2003 23:42:39 -0000 Received: from public by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1A5w2x-0001Yy-00 for ; Sun, 05 Oct 2003 01:42:47 +0200 Received: from jetty2.inetu.net ([209.235.192.112] helo=jetty.mortbay.com) by main.gmane.org with smtp (Exim 3.35 #1 (Debian)) id 1A5w2w-0001Yn-00 for ; Sun, 05 Oct 2003 01:42:46 +0200 Received: (qmail 23902 invoked from network); 4 Oct 2003 23:42:45 -0000 Received: from cpe-203-45-77-110.nsw.bigpond.net.au (HELO mortbay.com) (gregw@203.45.77.110) by jetty.mortbay.com with SMTP; 4 Oct 2003 23:42:45 -0000 Message-ID: <3F7F5AC8.3030408@mortbay.com> Date: Sun, 05 Oct 2003 09:42:00 +1000 From: Greg Wilkins User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030908 Debian/1.4-4 X-Accept-Language: en MIME-Version: 1.0 Newsgroups: gmane.comp.java.geronimo.devel To: public-geronimo-dev=d1GL8uUpDdXTxqt0kkDzDmD2FQJk+8+b@ciao.gmane.org Subject: Re: [webapp deployment] Progress (was Re: [Deployment] Application Deployment Status) References: <3F7E54F2.2060904@mortbay.com> <3F7F54BC.1090806@mortbay.com> In-Reply-To: <3F7F54BC.1090806@mortbay.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: Gmane Remailer X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Greg Wilkins ranted: > [...] > So I think the way forward is for: > Aaron - can you think how to cast your proposal in terms of generic > rather than specific APIs, such that the Web app deployer (where ever > that > may be) will see the same style of calls for a WAR in EAR deploy as it > would for a direct WAR deploy. > > Jan - can you look at you current code and give more details of the > steps & process that could like be given up to a common deployer. Having just chatted to Jan about this - I think I can say this more clearly as: So I think the way forward is to look at the DeploymentPlanner API and make sure that it conforms to JSR88 (eg at the very least planDeployment should not plan a start step). This needs to be done at the DeploymentPlanner level so that all deployers (service deployer, ear deployer, war deployer) will conform to JSR88. We then need to look at how one deployment planner can request the deployment of another unit and for it to supply additional context (eg for the ear deployer to request a war deployment, but with extra DDs). Finally, we then need to look at the common handling done by all deployers and make sure that is implemented only once (ie in an DeploymentPlannerSupport class or AbstractDeploymentPlanner or as a method of the deployment controller - whatever). Thus I think that the code that Aaron is talking about will end up in the DeploymenPlannerSupport and in an EARDeploymentPlanner. The code that Jan is talking about ends up in the Webapp deploymentplanner (which is the WebContainer) and it will use a DeploymentPlannerSupport. It does not really know or care if it get's called to deploy something the deployment scanner found or something that the EARDeploymentPlanner requested, it is all the same to it (except an additional DD will be passed in the context). cheers