geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeremy Boynes" <jer...@coredevelopers.net>
Subject RE: Few Concerns!!!
Date Sun, 28 Sep 2003 18:17:39 GMT
> From: Siva [mailto:siva@sivasundaram.com]
> Sent: Sunday, September 28, 2003 10:53 AM
>     I have the following few concerns with our codebase
>
> License headers
>
> 1) o.a.g.deployment.model.webAbstractWebApp is licensed to Core Developers
> network.Is it correct?
>

Fixed (sorry my bad, didn't spot the IDE had picked the wrong template)

> 2) Even the autogenerated Java classes should have the ASF license,right?

This may be a limitation of the generator. However, as they are machine
generated, I don't believe a specific license is needed.

>
>
> CR-LF
>
> Many files are still having improper line endings and moreover the recent
> commits also have
> this problem.Can the committers please ensure that the sources are run
> against "cleanse-sources"
> target?
>
> Author tags
>
> Author tags are still found in the following files took from our
> codebase.This may
> not be a serious concern but as we decided earlier,we should avoid having
> the author tag.
>
> o.a.g.common.net.protocol.resource.ResourceURLConnection.java

> o.a.g.deployment.model.web.AbstractWebApp.java
Fixed this one.

> o.a.g.web.AbstractWebConnectorMBean.java
> o.a.g.web.AbstractWebConnector.java
> o.a.g.web.jetty.JettyWebApplication.java
>
> Project website
>
> I have raised this issue many times with no answer.Anyway i again
> repeat,that we should
> update the maven generated document site.Can someone heed my request pls?
>

James, please can you do an update, it has been a very long time.

>
> Siva
>
>


Mime
View raw message