geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dain Sundstrom <>
Subject Re: cvs commit: incubator-geronimo/modules/console-web/src/webapp/images geronimo_logo_console.gif
Date Thu, 18 Sep 2003 06:15:14 GMT
On Thursday, September 18, 2003, at 12:35 AM, Greg Stein wrote:

> On Thu, Sep 18, 2003 at 04:45:26AM -0000, wrote:
> I see two issues here:
> 1) not a single file has an ASF copyright or license

Oops, my bad.  I forgot.  I'll add it now.

> 2) these "power plant" commits of large bodies of code are *very* hard 
> to
>    review. it is much nicer from a review standpoint to have this code
>    developed from scratch within the CVS repository. that provides a 
> way
>    to begin to gather input during development. as it stands, it will 
> be
>    very hard for somebody to review this whole thing and provide 
> credible
>    feedback, if any.

An initial import in a new area is an exception to the normal rule.  
The console did not work until last week and I just got the time to 
commit it.  Besides that, it is not much code to review (I did it in 30 


View raw message