Mailing-List: contact geronimo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: geronimo-dev@incubator.apache.org
Date: Mon, 18 Aug 2003 19:06:30 -0500
Mime-Version: 1.0 (Apple Message framework v552)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Subject: Notification when moving code
From: Dain Sundstrom <dain@coredevelopers.net>
To: geronimo-dev@incubator.apache.org
Content-Transfer-Encoding: 7bit
Message-Id: <FC2AB17D-D1D8-11D7-8482-000393DB559A@coredevelopers.net>

I just had a fairly bad CVS experience, and I know some others also 
have.  The problem is moving code.  This causes big problems for people 
with uncommitted changes, and makes for some very unhappy programmers.

I suggest that as a community that we agree to give at least 24 hours 
notice of [moving-code] <file-or-directory-name> to the mailing list.  
This rule would apply to core sections of code like 
org.apache.geronimo.common.State and modules like the move of jsr77 to 
j2ee-management.

I also suggest that committers take a good long look at a patch before 
committing it.  Is it using the correct code style?  Is the packaging 
correct?  Is it necessary?  I understand the urge to commit patches 
from contributors, but please help keep geronimo cruft free.

Given resent major changes to the system, I did a quick code review, 
and will send my notes in separate emails.

-dain

/*************************
  * Dain Sundstrom
  * Partner
  * Core Developers Network
  *************************/