Mailing-List: contact geronimo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: geronimo-dev@incubator.apache.org
Date: Sun, 17 Aug 2003 00:18:48 +0700
Subject: Re: [JSR-88] Recent Repackaging
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v552)
From: Jason Dillon <jason@coredevelopers.net>
To: geronimo-dev@incubator.apache.org
Content-Transfer-Encoding: 7bit
In-Reply-To: <Pine.LNX.4.44.0308161423460.8071-100000@www.princetongames.org>
Message-Id: <B2D07188-D00D-11D7-8A0D-000A9566A360@coredevelopers.net>

I think I have done that, double checking that a clean checkout 
functions.  I think there was only one test which depended upon core 
(DeploymentFactoryManagerTest).  If we want to test an impl then the 
core should create a test which extends the spec test and overrides the 
setup method to use an impl object instead of the mock.

--jason


On Sunday, August 17, 2003, at 01:30  AM, Aaron Mulder wrote:

> On Sat, 16 Aug 2003, Jason Dillon wrote:
>> I do not think they should be removed, the mock objects removed the
>> dependency on j2ee-deployment test from the core module.
>
> 	I think you have that backward, because now j2ee-deployment/test
> depends on the core module.  And if you want to keep the Mock objects,
> then we need to revert some of the tests, because they currently use 
> the
> real objects.  We'd probably also want to enhance the mock objects a 
> bit.
>
> Aaron
>