Mailing-List: contact geronimo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: geronimo-dev@incubator.apache.org
Message-ID: <12662190.1061957355657.JavaMail.orion@hogshead.codehaus.org>
Date: Tue, 26 Aug 2003 23:09:15 -0500 (CDT)
From: jira@codehaus.org
To: geronimo-dev@incubator.apache.org
Subject: [jira] Created: (GERONIMO-26) [patch] added null check to byte array
 equals and removed unneeded try-catch block
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=GERONIMO-26


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: GERONIMO-26
    Summary: [patch] added null check to byte array equals and removed unneeded try-catch block
       Type: Improvement

     Status: Unassigned
   Priority: Minor

 Time Spent: Unknown
  Remaining: Unknown

    Project: Apache Geronimo
 Components: 
             common

   Assignee: 
   Reporter: Brent Worden

    Created: Tue, 26 Aug 2003 11:08 PM
    Updated: Tue, 26 Aug 2003 11:08 PM

Description:
null checks weren't being performed in the equals(byte[], int, byte[], int, int) method.

remove the try-catch block from equals(byte[], byte[]) method because the length equality check prevents the exception from ever being thrown.

changes are complimented with a full battery of test cases.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira