Return-Path: Delivered-To: apmail-incubator-geronimo-dev-archive@incubator.apache.org Received: (qmail 67607 invoked by uid 500); 21 Aug 2003 05:40:55 -0000 Mailing-List: contact geronimo-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: geronimo-dev@incubator.apache.org Delivered-To: mailing list geronimo-dev@incubator.apache.org Received: (qmail 67573 invoked from network); 21 Aug 2003 05:40:54 -0000 Received: from adsl-209-233-18-245.dsl.snfc21.pacbell.net (HELO public.coredevelopers.net) (209.233.18.245) by daedalus.apache.org with SMTP; 21 Aug 2003 05:40:54 -0000 Received: from coredevelopers.net (dsundstrom-host236.dsl.visi.com [208.42.65.236]) (using TLSv1 with cipher DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by public.coredevelopers.net (Postfix on SuSE Linux 8.0 (i386)) with ESMTP id 125DA199FB for ; Wed, 20 Aug 2003 22:34:37 -0700 (PDT) Date: Thu, 21 Aug 2003 00:40:57 -0500 Subject: Re: [deployment][jsr77] Dependency code in AbstractStateManageable. Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v552) From: Dain Sundstrom To: geronimo-dev@incubator.apache.org Content-Transfer-Encoding: 7bit In-Reply-To: <3F44555E.1020100@mortbay.com> Message-Id: <09BEE7F9-D39A-11D7-8482-000393DB559A@coredevelopers.net> X-Mailer: Apple Mail (2.552) X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Thursday, August 21, 2003, at 12:15 AM, Greg Wilkins wrote: > -1+1 Can you leave the code dealing with the state machine in > AbstractStateManageable. ie the setStateInstance check of the > lifecycle and the doStart and doStop abstraction to separate tasks > for this object from any coordinated start processing. Sure, but why do you need AbstractStateManageable specifically? >> Drink a half dozen pints. > > +1 (so long as it is in the order above). I already drank a bottle of wine so I'm done.... > I also think you should make an ManagedContainer interface and > an AbstractManagedContainer class that would have all the > dependency service code in it. ie it would extend addComponent so > that a dependency is added to the dependency service when it is called. Well I did half of this. I added the rest of the types defined in 77 to the management package and added an AbstractStateMangeable which implements ManagedObject, StateManageable, and EventProvider (but not StatisticsProvider yet). I haven't touched the rest of the stuff in common yet, but I can when I wake up (unless you get to it first). > Actually... with that, I'd probably shut up on this issue as the > dependency mechanism integration into Component and Container would be > a lot more obvious - namely that the AbstractManagedContainer is really > just a conveniance class for configuring the dependency service. Okay... I glad we came to a good compromise. -dain