geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Blewitt <Alex.Blew...@ioshq.com>
Subject Re: [PATCH] Submitted directory structure for new 'mail' module
Date Tue, 26 Aug 2003 17:28:17 GMT
>> Please can you explain your reasoning why it is better in 'core' when 
>> other modules (web, twiddle, xmlbeans) clearly exist and such modules 
>> act as a suitable separation of code?
>
> The reason is that your patch did not have any code in it.  Take it 
> from my perspective if I go and create modules for everyone who 
> submitted a patch with no code, then we could end up with lots of 
> empty/stale modules.

It did not have code, but it had:

o Directory structure required for packages
o Project.xml file with documentation about that module and package 
names configured
o Resources for JavaMail implementation which will be required (which 
should be moved from the specs/javamail/resources directory)

Thus your assumption 'no code==empty' is invalid. Granted, it had no 
Java code, but it was not empty.

I am trying to work with others to co-ordinate the JavaMail 
implementation, and I wanted to set up the right structure/module so 
that people would use the right place for it. Indeed, I have said to 
one of the other developers on JavaMail that I would get the module set 
up so that he would have something to commit a patch against.

If you want to put some code in it, please feel free to add the 
following :

---
modules/mail/src/java/org/apache/geronimo/mail/AbstractTransport.java:

package org.apache.geronimo.mail;

import javax.mail.Transport;
public abstract class AbstractTransport extends Transport {
}
---

Thus there is now code for this patch.

Alex.


Mime
View raw message