geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ed Letifov <>
Subject Re[2]: [PATCH] JUnit test for org.apache.geronimo.cache.SimpleInstanceCache
Date Mon, 11 Aug 2003 23:04:21 GMT
Hello Bruce,

EL>> Anyway, the test is in the attachment. As I said before: started with
EL>> the simplest, hope it helps.

BS> I can certainly commit this test as I'll be writing a bunch of these
BS> later tonight.

Thank you, but still, how does one submit multiple new files? As a jar
archive to achieve portability and preserve directory/package

Also,  for  the  future, should the @author tags be specified? I don't
mind  an  impersonal  collective  ownership  at all, but I can imagine
someone  bugging  you  someday,  since  you  will  be the one actually
performing commit.

BS>  However, I'd like to try to make a decision on what we're
BS> going to do to to determine spec coverage first. Although spec coverage
BS> is crucial, we also just need some simple test coverage of the existing
BS> code base.

Understood. I guess while you are making this decision having the simple test
coverage growing won't hurt?

BS> I'm wondering if there's a need for two kinds of tests - unit and
BS> spec. Of course, these two can be achieved in the same * files
BS> and separated simply by a comment line.

I personally like the 'separate spec test' idea more, but I have to
admit that a gut feeling exists that it will end up in the same files,
and moreover without that comment line.

Best regards,

View raw message