geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel S. Haischt">
Subject Re: CR/LF cleansing
Date Sun, 31 Aug 2003 19:15:19 GMT
Jeremy Boynes wrote:

> What seems to be happening is that people are submitting tarballs in
> patches that contain DOS format files (CRLF). When these are expanded by
> people running Unix or MacOS, the CRLF is kept and the file committed as
> a Unix file with this is.

the problem is that CVS does indeed CRLF <-> LF line ending conversion.
but CVS expects LF terminated lines to be stored on the server. so if
CVS stores CRLF terminated files on the server, during the next checkout
on Windows you will end up with CRCRLF terminated lines because CVS sees
the LF and tries to convert the file (which is actually plain wrong in
that special case).


> So two things:
> 1) if you are running on Windows, please ensure you are using a text
> mode CVS
>    e.g. WinCVS or Cygwin cvs on a non-binary drive
> 2) if you are running on Unix, Linux or MacOS, please check all patch
> tarballs
>    for DOS-style CRLF before committing them

that is exactly what i was suggesting.


daniel s. haischt

View raw message