geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dain Sundstrom <d...@coredevelopers.net>
Subject Re: [PATCH] Submitted directory structure for new 'mail' module
Date Tue, 26 Aug 2003 17:38:46 GMT
Alex,

Chill.  We will add a mail module later, but we really don't need it 
now.  Right now core contains EJB and that will be moved later also.  
Once we get something going we will do a big refactor and move out EJB, 
mail and anything not deemed core.

-dain

On Tuesday, August 26, 2003, at 12:28 PM, Alex Blewitt wrote:

>>> Please can you explain your reasoning why it is better in 'core' 
>>> when other modules (web, twiddle, xmlbeans) clearly exist and such 
>>> modules act as a suitable separation of code?
>>
>> The reason is that your patch did not have any code in it.  Take it 
>> from my perspective if I go and create modules for everyone who 
>> submitted a patch with no code, then we could end up with lots of 
>> empty/stale modules.
>
> It did not have code, but it had:
>
> o Directory structure required for packages
> o Project.xml file with documentation about that module and package 
> names configured
> o Resources for JavaMail implementation which will be required (which 
> should be moved from the specs/javamail/resources directory)
>
> Thus your assumption 'no code==empty' is invalid. Granted, it had no 
> Java code, but it was not empty.
>
> I am trying to work with others to co-ordinate the JavaMail 
> implementation, and I wanted to set up the right structure/module so 
> that people would use the right place for it. Indeed, I have said to 
> one of the other developers on JavaMail that I would get the module 
> set up so that he would have something to commit a patch against.
>
> If you want to put some code in it, please feel free to add the 
> following :
>
> ---
> modules/mail/src/java/org/apache/geronimo/mail/AbstractTransport.java:
>
> package org.apache.geronimo.mail;
>
> import javax.mail.Transport;
> public abstract class AbstractTransport extends Transport {
> }
> ---
>
> Thus there is now code for this patch.
>
> Alex.
>
>

/*************************
  * Dain Sundstrom
  * Partner
  * Core Developers Network
  *************************/


Mime
View raw message