geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From em...@dds.nl
Subject Re: [PATCH] jsr88 DeploymentFactoryManager implementation + unittests
Date Thu, 14 Aug 2003 15:55:00 GMT
James,

Personaly I agree completely, but I discovered this behaviour while
writing the unittest against SUNs reference implementation. 
I had to remove the null check from my original code to make the test
failures go away. :)

Maas

Citeren James Strachan <james_strachan@yahoo.co.uk>:

> 
> On Thursday, August 14, 2003, at 06:31  am, Aaron Mulder wrote:
> 
> > Maas,
> >
> > 	Regarding this particular patch, I'd prefer that we don't actually
> > add "null" to the list of DeploymentFactories, even if it's passed as 
> > an
> > argument to DeploymentFactoryManager.registerDeploymentFactory().  
> > That's
> > silly, we should just ignore a null.
> 
> Failing fast with silly arguments is a good idea - e.g. throw an 
> IllegalArgumentException or NullPointerException.
> 
> James
> -------
> http://radio.weblogs.com/0112098/
> 
> 




Mime
View raw message