geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dain Sundstrom <d...@coredevelopers.net>
Subject Re: [i18n] Hardcoded message strings
Date Tue, 26 Aug 2003 18:13:34 GMT
-1 for the reason below and I believe this type of requirement on 
programmers will lead to worse exception handling.  If a developer has 
to add a new class for every exception message, they won't throw 
exceptions.

-dain

On Tuesday, August 26, 2003, at 12:51 PM, Cabrera, Alan wrote:

> Think about the ramifications of this proposal, it will lead to deep 
> and
> wide inheritance hierarchies for our exceptions.  Do we want this?
>
>
> Regards,
> Alan
>
>> -----Original Message-----
>> From: James Strachan [mailto:james_strachan@yahoo.co.uk]
>>
>> Agreed with all that.
>>
>> My only comment is - lets try put all the messages inside the
>> exception
>> classes. So that in Java code we throw the exception which accurately
>> describes what the exception is...
>>
>> e.g.
>>
>> throw new InsertOfEntityBeanFailedException(bean, sqlException,
>> errorCode);
>>
>> and there's no message / text in the throws clause. Then we can
>> refactor later to make the getLocalizedMessage() support i18n without
>> affecting the codebase much.
>>
>> This also allows for fine grained exception catching too.
>>
>>
>> On Tuesday, August 26, 2003, at 06:34  pm, Dain Sundstrom wrote:
>>
>>> Again we have the cart way ahead of the horse...
>>>
>>> We need to draw a line.  What are we gong to make i18 and
>> what are we
>>> going to leave in english.  When are we going to add i18?
>>>
>>> I suggest we come up with a way for us to add i18 later without any
>>> pain now (see my previous message).  Further, I suggest we make the
>>> rule that only user displayable messages and log messages > info
>>> support i18, but now Exceptions, debug, or trace.
>>>
>>> We have a huge project in front of us and we should do everything to
>>> make this a fast and enjoyable experience, and I find that editing
>>> messages bundles and working with message formatter to be
>> neither.  I
>>> think we should take a long breath and think about a way to make it
>>> easy add this later.
>>>
>>> -dain
>>>
>>> /*************************
>>>  * Dain Sundstrom
>>>  * Partner
>>>  * Core Developers Network
>>>  *************************/
>>>
>>>
>>
>> James
>> -------
>> http://radio.weblogs.com/0112098/
>>
>
>
> ----------------------------------------------------------------
>       Visit our Internet site at http://www.reuters.com
>
> Get closer to the financial markets with Reuters Messaging - for more
> information and to register, visit <http://www.reuters.com/messaging>
>
> Any views expressed in this message are those of  the  individual 
> sender,
> except  where  the sender specifically states them to be the views of 
> The
> Reuters Group.
>

/*************************
  * Dain Sundstrom
  * Partner
  * Core Developers Network
  *************************/


Mime
View raw message