geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siva" <s...@sivasundaram.com>
Subject Re: About patches
Date Tue, 26 Aug 2003 18:07:39 GMT
I verified the files and found missing licenses in 

BaseEjbBeanBeanInfo.java
ContextParamBeanInfo.java
EjbLocalRefBeanBeanInfo.java
EjbRefBeanBeanInfo.java
EntityBeanBeanInfo.java
EnvEntryBeanBeanInfo.java
JettyWebConnector.java
MessageDrivenBeanBeanInfo.java
ResourceEnvRefBeanBeanInfo.java
ResourceRefBeanBeanInfo.java
SecurityRoleRefBeanBeanInfo.java
SessionBeanBeanInfo.java

and CRLF issues in 

DeployerMBean.java
MuBooleanTest.java

Can someone correct them?

Siva

----- Original Message ----- 
From: "Jason Dillon" <jason@coredevelopers.net>
To: <geronimo-dev@incubator.apache.org>
Sent: Tuesday, August 26, 2003 10:38 PM
Subject: About patches


> This is my personal opinion, but I would prefer patches to be submitted 
> relative to the project root.  Looks like most patches have been, so no 
> big deal there.  However attachments of new files in JAR format are a 
> pain.  ZIP or TAR GZ files would be much easier to handle, with files 
> relative to the project root.
> 
> Also, it would be nice if you could include the license header and 
> proper class javadocs too, but that is minor.
> 
> --jason
> 

Mime
View raw message