geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mario Kevo (Jira)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-7301) Remove code that disables the use of hostnames in membership identifiers
Date Wed, 06 Nov 2019 10:23:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-7301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968242#comment-16968242
] 

Mario Kevo commented on GEODE-7301:
-----------------------------------

Hi [~bschuchardt] ,

As I see it checks _SocketCreator.resolve_dns_  and if this is *true* it will use *hostname*.
I found one place where this can be changed to false and it depends on network-partition-detection.
{code:java}
SocketCreator.resolve_dns = true;
if (theConfig.getEnableNetworkPartitionDetection()) {
 if (!SocketCreator.FORCE_DNS_USE) {
 SocketCreator.resolve_dns = false;
 }
}{code}
So we need remove this part, and also update all places where it checks if it is true or false
as it will be always true.

For example:
{code:java}
hostName = SocketCreator.resolve_dns
 ? SocketCreator.getCanonicalHostName(inetAddr, hostName) : inetAddr.getHostAddress();{code}
Am I correct?

BR,

Mario
  

> Remove code that disables the use of hostnames in membership identifiers
> ------------------------------------------------------------------------
>
>                 Key: GEODE-7301
>                 URL: https://issues.apache.org/jira/browse/GEODE-7301
>             Project: Geode
>          Issue Type: Improvement
>          Components: membership
>            Reporter: Bruce J Schuchardt
>            Assignee: Mario Kevo
>            Priority: Minor
>              Labels: low-hanging-fruit, newbie
>
> When network-partition-detection is enabled membership identifiers use numeric host IP
addresses instead of host names.  This should be changed to always use host names - much of
the rest of Geode uses hostnames regardless of how this setting is configured, so we're dependent
on the computer's host name resolution service anyway.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message