geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <>
Subject [jira] [Commented] (GEODE-6807) changing advisors to cache advice can improve performance
Date Wed, 23 Oct 2019 23:30:00 GMT


ASF subversion and git services commented on GEODE-6807:

Commit 80efe5cae9848f4fab45bb5c199c1e1f1fdf0eae in geode's branch refs/heads/feature/GEODE-7286
from Mario Ivanac
[;h=80efe5c ]

Revert "Revert "GEODE-6807: cache adviseUpdate and adviseAllEventsOrCached" (#4189)" (#4212)

* This reverts commit e225ffcd5dc8f15ae59b46dc24baefcc253801f2.

> changing advisors to cache advice can improve performance
> ---------------------------------------------------------
>                 Key: GEODE-6807
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: core
>            Reporter: Darrel Schneider
>            Assignee: Mario Ivanac
>            Priority: Major
>              Labels: performance
>          Time Spent: 5h 40m
>  Remaining Estimate: 0h
> Cluster messaging uses advisors to know what member of the cluster should be sent a message.
> Currently, every time and advisor is asked for advice to iterates over its profiles building
up the advice in a HashSet that is returned.
> I found on a partitioned region client/server put benchmark (32 client threads, 2 servers
with redundancy 1) that if I changed the method adviseAllEventsOrCached to remember what it
computed, that it caused the put throughput to increase by 8%. [Update I reran and did not
see an improvement so the original 8% difference may have been caused by something else].
> Advisors know when a profile is added, removed, or modified. When that happens any advice
it has cached can be dropped. Also, the requestors of advice need to expect the Set they get
back to be unmodifiable. 

This message was sent by Atlassian Jira

View raw message