geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Blake Bender (Jira)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-7235) Disable new Clang warnings to fix build for now
Date Wed, 25 Sep 2019 15:52:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-7235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937863#comment-16937863
] 

Blake Bender commented on GEODE-7235:
-------------------------------------

GEODE-7236 is tracking the actual fix for this in NC code.  Once that's in, this change needs
to be backed out so we take advantage of these compiler warnings.

> Disable new Clang warnings to fix build for now
> -----------------------------------------------
>
>                 Key: GEODE-7235
>                 URL: https://issues.apache.org/jira/browse/GEODE-7235
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Blake Bender
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Apple pushed an XCode update a couple of days ago to version `
> Apple clang version 11.0.0 (clang-1100.0.33.8)`.  This version flags some new warnings
in our code, and since we have warnings-as-errors turned on we blow up.  Fixing these warnings
is non-trivial, so we need to disable them in the top-level CMakeLists.txt and file another
Jira issue to do the real fix.
> * Steps to repro:
> Sync up to the latest `develop` branch of Native Client on a Mac and build
> * Expected Result:
> Geode Native builds, and produces our libraries
> * Actual Result:
> Clang warns about "implicitly deleted copy/move ctors declared as default" in a product
header, gives a warning about UTF-8 string literals in test code, then build fails.  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message