geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <>
Subject [jira] [Commented] (GEODE-7150) Use LONG instead of INT in Aggregation Functions
Date Fri, 13 Sep 2019 18:17:00 GMT


ASF subversion and git services commented on GEODE-7150:

Commit fbb210632ca773f41736cbe5cc26b0cd17a5698b in geode's branch refs/heads/feature/GEODE-7196
from Juan José Ramos
[;h=fbb2106 ]

GEODE-7150: Use Long in OQL COUNT and AVG (#3994)

- Use 'long' instead of 'int' to compute OQL COUNT result.
- Use 'long' instead of 'int' to compute OQL AVG intermediate results.

> Use LONG instead of INT in Aggregation Functions
> ------------------------------------------------
>                 Key: GEODE-7150
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: querying
>            Reporter: Juan José Ramos Cassella
>            Assignee: Juan José Ramos Cassella
>            Priority: Major
>              Labels: GeodeCommons
>             Fix For: 1.11.0
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
> OQL aggregate functions ({{COUNT}} and {{AVG}}) can “silently” overflow as Geode
internally uses {{int}} to compute the aggregations, basically meaning that we can return
an overflowed value instead of the proper result.
> As an example, if {{COUNT}} evaluates to {{2147483648 (Integer.MAX_VALUE + 1)}} the user
will receive {{-2147483648 (Integer.MIN_VALUE)}} and so on.
> We should modify the internal implementation to use `Long` instead of `Int`, and properly
document the limitation (see GEODE-7146).

This message was sent by Atlassian Jira

View raw message