geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dick Cavender (Jira)" <j...@apache.org>
Subject [jira] [Closed] (GEODE-6825) Specify workingDirectory when creating GMSLocator
Date Thu, 26 Sep 2019 18:04:08 GMT

     [ https://issues.apache.org/jira/browse/GEODE-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dick Cavender closed GEODE-6825.
--------------------------------

> Specify workingDirectory when creating GMSLocator
> -------------------------------------------------
>
>                 Key: GEODE-6825
>                 URL: https://issues.apache.org/jira/browse/GEODE-6825
>             Project: Geode
>          Issue Type: Improvement
>          Components: locator
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>            Priority: Minor
>             Fix For: 1.10.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> I want to be able to specify the workingDirectory when constructing a GMSLocator which
will then be used for the location of the locator view files (locator<pid>view.dat).
Tests would use the TemporaryFolder JUnit Rule to specify a workingDirectory for the location
of the locator view files. This will eliminate the potential for file system pollution of
locator view files and guarantee better cleanup especially when running tests from an IDE.
> Default value for workingDirectory is System.getProperty("user.dir").
> At first, I intend to use this from tests that use LocatorLauncher. The full path from
LocatorLauncher to GMSLocator is:
> LocatorLauncher.start()
> -> InternalLocator.startLocator(int, File, InternalLogWriter, InternalLogWriter, InetAddress,
boolean, Properties, String)
> -> InternalLocator.startPeerLocation()
> -> MemberFactory.newLocatorHandler(InetAddress, String, boolean, boolean, LocatorStats,
String)
> -> GMSMemberFactory.newLocatorHandler(InetAddress, String, boolean, boolean, LocatorStats,
String)
> -> GMSLocator.GMSLocator(InetAddress, String, boolean, boolean, LocatorStats, String)
> Proposed implementation is to add a String field and constructor parameter for the absolute
workingDirectory path to these classes:
> * InternalLocator
> * GMSLocator
> And, finally the following methods would have a new String parameter for workingDirectory
added to them:
> * InternalLocator.startLocator(int, File, InternalLogWriter, InternalLogWriter, InetAddress,
boolean, Properties, String, *_String_*)
> * MemberFactory.newLocatorHandler(InetAddress, String, boolean, boolean, LocatorStats,
String, *_String_*)
> * GMSMemberFactory.newLocatorHandler(InetAddress, String, boolean, boolean, LocatorStats,
String, *_String_*)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message