From issues-return-52814-archive-asf-public=cust-asf.ponee.io@geode.apache.org Thu Aug 29 04:25:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3AAD818065E for ; Thu, 29 Aug 2019 06:25:02 +0200 (CEST) Received: (qmail 33855 invoked by uid 500); 29 Aug 2019 04:25:01 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 33839 invoked by uid 99); 29 Aug 2019 04:25:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Aug 2019 04:25:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CDE01E30E3 for ; Thu, 29 Aug 2019 04:25:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 1F644780C5C for ; Thu, 29 Aug 2019 04:25:00 +0000 (UTC) Date: Thu, 29 Aug 2019 04:25:00 +0000 (UTC) From: "ASF subversion and git services (Jira)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-6941) commands/code in goede-core should use the auto-generated configuration objects MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-6941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918276#comment-16918276 ] ASF subversion and git services commented on GEODE-6941: -------------------------------------------------------- Commit b6e7b077f86b63ccbb52c6e383006531932cfef6 in geode's branch refs/heads/develop from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b6e7b07 ] GEODE-6941: move xml configuration objects to core (#3978) * GEODE-6941: move xml configuration objects to core Co-authored-by: Darrel Schneider * CacheElement and other xml configuration should only exists in core * use AbstractConfiguration in geode-management * keep all xml domain objects in the same package as before and keep CacheElement an abstract class. > commands/code in goede-core should use the auto-generated configuration objects > ------------------------------------------------------------------------------- > > Key: GEODE-6941 > URL: https://issues.apache.org/jira/browse/GEODE-6941 > Project: Geode > Issue Type: Sub-task > Components: management > Reporter: Jinmei Liao > Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > some gfsh commands have started using these configuration objects for xml persistence, and they are using the modified classes, we should move these modified convenience methods into some utility methods and make sure these classes are using the auto-generated xml domain objects as it is. > 1. regenerate the jaxb objects into an internal package in geode-core > 2. modify the gfsh commands in core to use these objects instead of the objects in geode-management > 3. leave the geode-management objects intact for now. -- This message was sent by Atlassian Jira (v8.3.2#803003)