geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-6883) Move the membership code into a separate gradle sub-project
Date Mon, 22 Jul 2019 22:44:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-6883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890517#comment-16890517
] 

ASF subversion and git services commented on GEODE-6883:
--------------------------------------------------------

Commit b292745c2f743ad6fe48a7eb1d0ad5333a0d0029 in geode's branch refs/heads/feature/remove-InternalDistributedMember-GEODE-6883
from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b292745 ]

GEODE-6883 Move the membership code into a separate gradle sub-project

This PR narrows the effort of GEODE-6883 to focus only on the "gms"
package and its subpackages.  Other membership classes in
org.apache.geode.distributed.internal.membership are Geode interfaces,
adapters and factories.  Classes in "gms" are membership
classes/interfaces that should not refer to anything outside of "gms"
(though they still do).

This PR is otherwise focused on removing references to
InternalDistributedMember and DistributionMessage from "gms".

    GMS classes only refer to GMSMember
    GMS classes use GMSMembershipView.  NetView is now an interface
    GMS classes do not refer to DistributionMessage.  JGroupsMessenger
      expects GMSMessage instances.  Geode messages to be sent over UDP
      are wrapped in a GMSMessageAdapter.
    "gms" messages extend AbstractGMSMessage which implements GMSMessage
    GMSMembershipManager has an inner class that implements the GMS Manager
      interface and is now in the "adapter" package
    GMSMembershipManager translates GMSMembershipView into a MembershipView
      for the rest of Geode to use (this is the old NetView class)
    GMS instantiation allows us to inject the Manager into the new Services
      instance.
    Other adapter classes have been added to translate between Geode
      and GMS.

    GMSUtil has new methods for marshalling/unmarshalling
    InternalDistributedMember instances for backward-compatibility.
    GMSMember now has the same on-wire form as
    InternalDistributedMember.  This allows the GMS classes to
    deserialize a message from a pre-1.10 member whose code writes
    InternalDistributedMembers when serializing something like a
    JoinRequest.


> Move the membership code into a separate gradle sub-project
> -----------------------------------------------------------
>
>                 Key: GEODE-6883
>                 URL: https://issues.apache.org/jira/browse/GEODE-6883
>             Project: Geode
>          Issue Type: Improvement
>          Components: membership
>            Reporter: Dan Smith
>            Priority: Major
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> In order to make membership more testable, we want to move the membership code out of
geode-core and into a new geode-membership gradle sub-project.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message