From issues-return-47080-archive-asf-public=cust-asf.ponee.io@geode.apache.org Fri Feb 1 22:31:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6F559180627 for ; Fri, 1 Feb 2019 23:31:05 +0100 (CET) Received: (qmail 41830 invoked by uid 500); 1 Feb 2019 22:31:03 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 41682 invoked by uid 99); 1 Feb 2019 22:31:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2019 22:31:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 63C82C2485 for ; Fri, 1 Feb 2019 22:31:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 1BjJF7dFpU7X for ; Fri, 1 Feb 2019 22:31:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 405C86105E for ; Fri, 1 Feb 2019 22:31:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7D3AEE2072 for ; Fri, 1 Feb 2019 22:31:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 34F93243D9 for ; Fri, 1 Feb 2019 22:31:00 +0000 (UTC) Date: Fri, 1 Feb 2019 22:31:00 +0000 (UTC) From: "Shelley Lynn Hughes-Godfrey (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (GEODE-6344) should revert GEODE-1183 before a better fix MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shelley Lynn Hughes-Godfrey updated GEODE-6344: ----------------------------------------------- Description: GEODE-1183 was introduced for a scenario that there're 2 cache-servers at the same jvm, the client will try to create 2 proxy to the server, but since it's the same proxy id, it would end up close/recreate forever. GEODE-1183 will reject an incoming create-proxy request if the server found there's an existing proxy with the same id and its socket is still connected. However, this fix caused some side effects. For example, if the client read time out, it requested the server to recreate the proxy, the server will reject this request and the client will never reconnect. This is due to that at the server side, it cannot determine it's a reconnect request or the same client requests to connect to the 2nd cache-server on the same jvm. There's a proposal to introduce a parameter at the client to fix it. However, before this new re-fix, we decided to revert the original GEODE-1183 to avoid its side-effect. was: GEODE-1183 was introduced for a scenario that there're 2 cache-servers at the same jvm, the client will try to create 2 proxy to the server, but since it's the same proxy id, it would end up close/recreate forever. GEODE-1183 will reject an incoming create-proxy request if the server found there's an existing proxy with the same id and its socket is still connected. However, this fix caused some side effects. For example, if the client read time out, it requested the server to recreate the proxy, the server will reject this request and the client will never reconnect. This is due to that at the server side, it cannot determine it's a reconnect request or the same client requests to connect to the 2nd cache-server on the same jvm. There's a proposal to introduce a parameter at the client to fix it. However, before this new re-fix, we decided to revert the original GEODE-1183 to avoid its side-effect. This will be applied to geode 1.9.0, then cherrypick to 1.8, 1.7, 1.6, and 1.4. > should revert GEODE-1183 before a better fix > -------------------------------------------- > > Key: GEODE-6344 > URL: https://issues.apache.org/jira/browse/GEODE-6344 > Project: Geode > Issue Type: Bug > Reporter: xiaojian zhou > Assignee: xiaojian zhou > Priority: Major > Labels: pull-request-available > Fix For: 1.9.0 > > Time Spent: 20m > Remaining Estimate: 0h > > GEODE-1183 was introduced for a scenario that there're 2 cache-servers at the same jvm, the client will try to create 2 proxy to the server, but since it's the same proxy id, it would end up close/recreate forever. > GEODE-1183 will reject an incoming create-proxy request if the server found there's an existing proxy with the same id and its socket is still connected. > However, this fix caused some side effects. For example, if the client read time out, it requested the server to recreate the proxy, the server will reject this request and the client will never reconnect. > This is due to that at the server side, it cannot determine it's a reconnect request or the same client requests to connect to the 2nd cache-server on the same jvm. > There's a proposal to introduce a parameter at the client to fix it. However, before this new re-fix, we decided to revert the original GEODE-1183 to avoid its side-effect. -- This message was sent by Atlassian JIRA (v7.6.3#76005)