geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-6353) Remove SecurityConfig ThreadLocal
Date Mon, 04 Feb 2019 17:24:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-6353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760041#comment-16760041
] 

ASF subversion and git services commented on GEODE-6353:
--------------------------------------------------------

Commit 81f0497efd2ea299e17a16bb4355a0defe61ced0 in geode's branch refs/heads/develop from
Galen O'Sullivan
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=81f0497 ]

GEODE-6353: remove the ThreadLocal from SecurityConfig. (#3154)

* GEODE-6353: remove the ThreadLocal from SecurityConfig.

* Extract `DistributedSystem.connect()` to `InternalDistributedSystem.connectInternal()` so
that parameters can be passed in.
* Make `DistributedSystem.existingSystems` a
`List<InternalDistributedSystem>.
* Add a comment making it clear that users should never override `DistributedSystem`.
* Remove commented code


> Remove SecurityConfig ThreadLocal
> ---------------------------------
>
>                 Key: GEODE-6353
>                 URL: https://issues.apache.org/jira/browse/GEODE-6353
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Galen O'Sullivan
>            Assignee: Galen O'Sullivan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> SecurityConfig uses a ThreadLocal to pass the SecurityConfig object into InternalDistributedSystem.
This should be passed in to the create method and constructor instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message