geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-6328) gfsh show missing-disk-stores lists duplicate disk stores
Date Sat, 02 Feb 2019 01:16:01 GMT


ASF subversion and git services commented on GEODE-6328:

Commit 8e32605e8ca026eb28f4c6095dfbcaca5cbd09a1 in geode's branch refs/heads/feature/GEODE-6291
from Dan Smith
[;h=8e32605 ]

GEODE-6329, GEODE-6328: Fix issues with show missing-disk-stores (#3136)

* Using consistent logic for finding missing disk stores

The gfsh command for finding missing disk stores was not ignoring
present disk stores. However, the JMX command was. The gfsh command was also not deduplicating
the missing disk stores. Changing the gfsh command to use the JMX logic.

* Making sure member is removed from persistent view

When we start up a member that has persistent data that it should delete
(due to already established redundancy), the member was not correctly
removing members from it's persistent view in
PersistenceAdvisorImpl.updateMembershipView. This was due to the fact
that the destroyOfflineData method was clearing the recoveredMembers
set, but not the underlying persistentMemberView.

The persistentMemberView probably should be preserved, in case the
member is killed and restarted before it gets a new view. So we should
reset the recoveredMembers set to the correct value.

* Simplifying the logic for reporting present disk stores

The logic for reporting what disk stores were actually running on a
node, for the purposes of not reporting those disk stores as missing,
was overly complicated. Due to that, it only included disk stores that
actually had any persistent regions/buckets on that node, rather than
all disk stores.

Refactoring the code to just list all disk stores.

> gfsh show missing-disk-stores lists duplicate disk stores
> ---------------------------------------------------------
>                 Key: GEODE-6328
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: management
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>            Priority: Major
>             Fix For: 1.9.0
> The gfsh command show missing-disk-stores is listing the same disk store multiple times:
> {noformat}
> Command result for <show missing-disk-stores>: 
> Missing Disk Stores
>            Disk Store ID             |      Host      | Directory
> ------------------------------------ | -------------- | ---------------------------------------------------------------------------
> e51f6f5b-00c6-4d00-9a7b-9e161498422e | / | /Users/dsmith/Documents/Code/gemfire/open/geode-core/dunit/vm1/diskStoreDir
> e51f6f5b-00c6-4d00-9a7b-9e161498422e | / | /Users/dsmith/Documents/Code/gemfire/open/geode-core/dunit/vm1/diskStoreDir
> No missing colocated region found
> {noformat}
> Looking at the code, it looks like gfsh gathers the missing disk stores reported from
each member and just adds them to a list, rather than deduplicating them.

This message was sent by Atlassian JIRA

View raw message