geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Rhomberg (JIRA)" <>
Subject [jira] [Commented] (GEODE-4811) Add a feature-flag annotation to gfsh commands
Date Thu, 08 Mar 2018 23:05:03 GMT


Patrick Rhomberg commented on GEODE-4811:

I guess it depends on whether or not you want it to be completely inaccessible, or just difficult
to access.

I think there would be use in having them hidden behind a system property, and then being
able to access them via {{JAVA_ARGS=-Dmy.feature.flag=true gfsh}}.  Although I suppose an
annotation {{@Disabled}} could also take a flag, like {{@Disabled(unless = "my.feature.flag")}}

> Add a feature-flag annotation to gfsh commands
> ----------------------------------------------
>                 Key: GEODE-4811
>                 URL:
>             Project: Geode
>          Issue Type: New Feature
>          Components: gfsh
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>            Priority: Major
> Many gfsh commands are mutually required by each other for full functionality.  For instance,
{{destroy jndi-binding}} is meaningless without the {{create jndi-binding}} command.
> As a developer, I would like to be able to coordinate release of multiple related commands
at once, across multiple commits.  A {{@FeatureFlag}} annotation on gfsh command classes would
be extremely useful.

This message was sent by Atlassian JIRA

View raw message