From issues-return-31719-archive-asf-public=cust-asf.ponee.io@geode.apache.org Fri Feb 23 19:04:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5FFB7180787 for ; Fri, 23 Feb 2018 19:04:08 +0100 (CET) Received: (qmail 33414 invoked by uid 500); 23 Feb 2018 18:04:07 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 33314 invoked by uid 99); 23 Feb 2018 18:04:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Feb 2018 18:04:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DB3501A01F7 for ; Fri, 23 Feb 2018 18:04:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.311 X-Spam-Level: X-Spam-Status: No, score=-102.311 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id adAkMnVufkXE for ; Fri, 23 Feb 2018 18:04:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0992B5FD1B for ; Fri, 23 Feb 2018 18:04:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 98A6BE00D6 for ; Fri, 23 Feb 2018 18:04:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8A0FD255DB for ; Fri, 23 Feb 2018 18:04:01 +0000 (UTC) Date: Fri, 23 Feb 2018 18:04:01 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-4722) Code Improvement: Refactor CliUtil MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-4722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374756#comment-16374756 ] ASF subversion and git services commented on GEODE-4722: -------------------------------------------------------- Commit df093b5b8f2d1bee549e0b76472b4fcdd51ddc7f in geode's branch refs/heads/develop from [~prhomberg] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=df093b5 ] GEODE-4722: Refactor CliUtil (#1487) * Reorder methods, grouped by similar functionality. * Replace .stackTraceToString and .contains with Apache Commons methods. * Moved getClientIdFromCacheClientProxy to only class that calls it. * Move arrayToString from CliUtil to sensible StringUtils. Moved associated test. * Refactor CliUtil methods. > Code Improvement: Refactor CliUtil > ---------------------------------- > > Key: GEODE-4722 > URL: https://issues.apache.org/jira/browse/GEODE-4722 > Project: Geode > Issue Type: Improvement > Reporter: Patrick Rhomberg > Assignee: Patrick Rhomberg > Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > This class could use some cleaning. Many methods are unused, some trivially replaced by Apache Commons libraries. -- This message was sent by Atlassian JIRA (v7.6.3#76005)