From issues-return-31858-archive-asf-public=cust-asf.ponee.io@geode.apache.org Tue Feb 27 18:42:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 49377180651 for ; Tue, 27 Feb 2018 18:42:04 +0100 (CET) Received: (qmail 60916 invoked by uid 500); 27 Feb 2018 17:42:03 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 60906 invoked by uid 99); 27 Feb 2018 17:42:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Feb 2018 17:42:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CFCCC1A045B for ; Tue, 27 Feb 2018 17:42:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id vugaiSnOnQsg for ; Tue, 27 Feb 2018 17:42:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9D2935F521 for ; Tue, 27 Feb 2018 17:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2CA5EE0177 for ; Tue, 27 Feb 2018 17:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DAF862408C for ; Tue, 27 Feb 2018 17:42:00 +0000 (UTC) Date: Tue, 27 Feb 2018 17:42:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-4541) Remove singleton calls from regions product code in org.apache.geode.internal.cache MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378999#comment-16378999 ] ASF subversion and git services commented on GEODE-4541: -------------------------------------------------------- Commit d752dceaee450ce4d49dcd06766b3dd665211e16 in geode's branch refs/heads/feature/GEODE-4685 from [~dschneider] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=d752dce ] GEODE-4541: remove singleton calls (#1463) * removed getAnyInstance call from PartitionedRegionHelper * removed getInstance call from CacheServerLauncher * removed getAnyInstance call from EventStateHelper * DistributedPutAllOperation no longer calls GemFireCacheImpl.getInstance * EntryEventImpl no longer calls getInstance. This fix requires that when an EntryEventImpl is deserialized that setRegion will be called on it before the values are accessed. Also encapsulated the "region" field and got rid of getLocalRegion in favor of getRegion. > Remove singleton calls from regions product code in org.apache.geode.internal.cache > ----------------------------------------------------------------------------------- > > Key: GEODE-4541 > URL: https://issues.apache.org/jira/browse/GEODE-4541 > Project: Geode > Issue Type: Sub-task > Components: regions > Reporter: Kirk Lund > Assignee: Darrel Schneider > Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > These regions product classes in org.apache.geode.internal.cache invoke singleton getters. > GemFireCacheImpl.getInstance(): > * CacheServerLauncher > * EntryEventImpl > * GemFireCacheImpl > * DistributedPutAllOperation > InternalDistributedSystem.getAnyInstance(): > * EventStateHelper > * GemFireCacheImpl > * PartitionAttributesImpl > * PartitionedRegionHelper -- This message was sent by Atlassian JIRA (v7.6.3#76005)