From issues-return-31797-archive-asf-public=cust-asf.ponee.io@geode.apache.org Mon Feb 26 18:44:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3300218077D for ; Mon, 26 Feb 2018 18:44:07 +0100 (CET) Received: (qmail 14487 invoked by uid 500); 26 Feb 2018 17:44:06 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 14326 invoked by uid 99); 26 Feb 2018 17:44:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Feb 2018 17:44:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 96047C0040 for ; Mon, 26 Feb 2018 17:44:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id IpOGf55e7I9n for ; Mon, 26 Feb 2018 17:44:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 996275FD30 for ; Mon, 26 Feb 2018 17:44:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 78397E0A8F for ; Mon, 26 Feb 2018 17:44:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1968A255F7 for ; Mon, 26 Feb 2018 17:44:01 +0000 (UTC) Date: Mon, 26 Feb 2018 17:44:01 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-4541) Remove singleton calls from regions product code in org.apache.geode.internal.cache MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377240#comment-16377240 ] ASF subversion and git services commented on GEODE-4541: -------------------------------------------------------- Commit d752dceaee450ce4d49dcd06766b3dd665211e16 in geode's branch refs/heads/feature/GEODE-4738 from [~dschneider] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=d752dce ] GEODE-4541: remove singleton calls (#1463) * removed getAnyInstance call from PartitionedRegionHelper * removed getInstance call from CacheServerLauncher * removed getAnyInstance call from EventStateHelper * DistributedPutAllOperation no longer calls GemFireCacheImpl.getInstance * EntryEventImpl no longer calls getInstance. This fix requires that when an EntryEventImpl is deserialized that setRegion will be called on it before the values are accessed. Also encapsulated the "region" field and got rid of getLocalRegion in favor of getRegion. > Remove singleton calls from regions product code in org.apache.geode.internal.cache > ----------------------------------------------------------------------------------- > > Key: GEODE-4541 > URL: https://issues.apache.org/jira/browse/GEODE-4541 > Project: Geode > Issue Type: Sub-task > Components: regions > Reporter: Kirk Lund > Assignee: Darrel Schneider > Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > These regions product classes in org.apache.geode.internal.cache invoke singleton getters. > GemFireCacheImpl.getInstance(): > * CacheServerLauncher > * EntryEventImpl > * GemFireCacheImpl > * DistributedPutAllOperation > InternalDistributedSystem.getAnyInstance(): > * EventStateHelper > * GemFireCacheImpl > * PartitionAttributesImpl > * PartitionedRegionHelper -- This message was sent by Atlassian JIRA (v7.6.3#76005)