From issues-return-28847-archive-asf-public=cust-asf.ponee.io@geode.apache.org  Fri Jan 12 19:12:07 2018
Return-Path: <issues-return-28847-archive-asf-public=cust-asf.ponee.io@geode.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id D0028180621
	for <archive-asf-public@eu.ponee.io>; Fri, 12 Jan 2018 19:12:07 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id C04BB160C33; Fri, 12 Jan 2018 18:12:07 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 91F21160C20
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 12 Jan 2018 19:12:06 +0100 (CET)
Received: (qmail 15869 invoked by uid 500); 12 Jan 2018 18:12:05 -0000
Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@geode.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@geode.apache.org>
List-Post: <mailto:issues@geode.apache.org>
List-Id: <issues.geode.apache.org>
Reply-To: dev@geode.apache.org
Delivered-To: mailing list issues@geode.apache.org
Received: (qmail 15860 invoked by uid 99); 12 Jan 2018 18:12:05 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jan 2018 18:12:05 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4C2021A0214
	for <issues@geode.apache.org>; Fri, 12 Jan 2018 18:12:05 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -99.911
X-Spam-Level:
X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31
	tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7,
	SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100]
	autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id CwaMSHDVud93 for <issues@geode.apache.org>;
	Fri, 12 Jan 2018 18:12:02 +0000 (UTC)
Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 401635F485
	for <issues@geode.apache.org>; Fri, 12 Jan 2018 18:12:01 +0000 (UTC)
Received: from jira-lw-us.apache.org (unknown [207.244.88.139])
	by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 77FBAE0C18
	for <issues@geode.apache.org>; Fri, 12 Jan 2018 18:12:00 +0000 (UTC)
Received: from jira-lw-us.apache.org (localhost [127.0.0.1])
	by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1918F25BD4
	for <issues@geode.apache.org>; Fri, 12 Jan 2018 18:12:00 +0000 (UTC)
Date: Fri, 12 Jan 2018 18:12:00 +0000 (UTC)
From: "Sai Boorlagadda (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13130597.1515780568000.639315.1515780720101@Atlassian.JIRA>
In-Reply-To: <JIRA.13130597.1515780568000@Atlassian.JIRA>
References: <JIRA.13130597.1515780568000@Atlassian.JIRA> <JIRA.13130597.1515780568578@jira-lw-us.apache.org>
Subject: [jira] [Updated] (GEODE-4291) Reducing the scope of JLineShell
 dependency for non-interactive clients.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/GEODE-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sai Boorlagadda updated GEODE-4291:
-----------------------------------
    Description: 
When using *SSL*, clients have to include *org.springframework.shell:spring-shell* dependency as geode expects the class on the class path and fails with below exception:

{noformat}
[error 2018/01/12 09:56:57.829 PST <main> tid=0x1] java.lang.NoClassDefFoundError: org/springframework/shell/core/JLineShell
Exception in thread "main" java.lang.NoClassDefFoundError: org/springframework/shell/core/JLineShell
        at java.lang.ClassLoader.defineClass1(Native Method)
        at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
        at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
        at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
        at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
        at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
        at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        at org.apache.geode.internal.GfeConsoleReaderFactory.createConsoleReader(GfeConsoleReaderFactory.java:42)
        at org.apache.geode.internal.GfeConsoleReaderFactory.<clinit>(GfeConsoleReaderFactory.java:33)
        at org.apache.geode.internal.net.SocketCreator.getKeyManagers(SocketCreator.java:537)
        at org.apache.geode.internal.net.SocketCreator.createAndConfigureSSLContext(SocketCreator.java:395)
        at org.apache.geode.internal.net.SocketCreator.initialize(SocketCreator.java:352)
        at org.apache.geode.internal.net.SocketCreator.<init>(SocketCreator.java:269)
        at org.apache.geode.internal.net.SocketCreatorFactory.createSSLSocketCreator(SocketCreatorFactory.java:105)
        at org.apache.geode.internal.net.SocketCreatorFactory.getSSLSocketCreator(SocketCreatorFactory.java:79)
        at org.apache.geode.internal.net.SocketCreatorFactory.getOrCreateSocketCreatorForSSLEnabledComponent(SocketCreatorFactory.java:95)
        at org.apache.geode.internal.net.SocketCreatorFactory.getSocketCreatorForComponent(SocketCreatorFactory.java:70)
        at org.apache.geode.distributed.internal.tcpserver.TcpClient.<init>(TcpClient.java:74)
        at org.apache.geode.cache.client.internal.AutoConnectionSourceImpl.<init>(AutoConnectionSourceImpl.java:118)
        at org.apache.geode.cache.client.internal.PoolImpl.getSourceImpl(PoolImpl.java:651)
        at org.apache.geode.cache.client.internal.PoolImpl.<init>(PoolImpl.java:248)
        at org.apache.geode.cache.client.internal.PoolImpl.create(PoolImpl.java:157)
        at org.apache.geode.internal.cache.PoolFactoryImpl.create(PoolFactoryImpl.java:338)
        at org.apache.geode.internal.cache.GemFireCacheImpl.determineDefaultPool(GemFireCacheImpl.java:2919)
        at org.apache.geode.internal.cache.GemFireCacheImpl.initializeDeclarativeCache(GemFireCacheImpl.java:1394)
        at org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1219)
        at org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:768)
        at org.apache.geode.internal.cache.GemFireCacheImpl.createClient(GemFireCacheImpl.java:740)
        at org.apache.geode.cache.client.ClientCacheFactory.basicCreate(ClientCacheFactory.java:264)
        at org.apache.geode.cache.client.ClientCacheFactory.create(ClientCacheFactory.java:213)
        at org.apache.geode.examples.clientSecurity.Example.<init>(Example.java:70)
        at org.apache.geode.examples.clientSecurity.Example.adminUserCanPutAndGetEverywhere(Example.java:86)
        at org.apache.geode.examples.clientSecurity.Example.main(Example.java:78)
Caused by: java.lang.ClassNotFoundException: org.springframework.shell.core.JLineShell
        at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 38 more
{noformat}

As you can see in below code *GfeConsoleReader* is initialized and is at the beginning of the function which causes the above exception. While this should be a dependency only for gfsh (to read inputs from the interactive shell) and not for non-interactive clients (consider a default).

{code}
private KeyManager[] getKeyManagers() throws KeyStoreException, IOException,
      NoSuchAlgorithmException, CertificateException, UnrecoverableKeyException {
    GfeConsoleReader consoleReader = GfeConsoleReaderFactory.getDefaultConsoleReader();

    if (sslConfig.getKeystore() == null) {
      return null;
    }

    KeyManager[] keyManagers = null;
    String keyStoreType = sslConfig.getKeystoreType();
    if (StringUtils.isEmpty(keyStoreType)) {
      // read from console, default on empty
      if (consoleReader.isSupported()) {
        keyStoreType =
            consoleReader.readLine("Please enter the keyStoreType (javax.net.ssl.keyStoreType) : ");
      } else {
        keyStoreType = KeyStore.getDefaultType();
      }
    }
{code}

A proposed fix is to avoid creating the `GfeConsoleReader` upfront and only do when it is required (for interactive shells).

  was:
When using *SSL*, clients have to include *org.springframework.shell:spring-shell:1.2.0.RELEASE* dependency as geode expects the class on the class path and fails with below exception:

{noformat}
[error 2018/01/12 09:56:57.829 PST <main> tid=0x1] java.lang.NoClassDefFoundError: org/springframework/shell/core/JLineShell
Exception in thread "main" java.lang.NoClassDefFoundError: org/springframework/shell/core/JLineShell
        at java.lang.ClassLoader.defineClass1(Native Method)
        at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
        at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
        at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
        at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
        at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
        at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        at org.apache.geode.internal.GfeConsoleReaderFactory.createConsoleReader(GfeConsoleReaderFactory.java:42)
        at org.apache.geode.internal.GfeConsoleReaderFactory.<clinit>(GfeConsoleReaderFactory.java:33)
        at org.apache.geode.internal.net.SocketCreator.getKeyManagers(SocketCreator.java:537)
        at org.apache.geode.internal.net.SocketCreator.createAndConfigureSSLContext(SocketCreator.java:395)
        at org.apache.geode.internal.net.SocketCreator.initialize(SocketCreator.java:352)
        at org.apache.geode.internal.net.SocketCreator.<init>(SocketCreator.java:269)
        at org.apache.geode.internal.net.SocketCreatorFactory.createSSLSocketCreator(SocketCreatorFactory.java:105)
        at org.apache.geode.internal.net.SocketCreatorFactory.getSSLSocketCreator(SocketCreatorFactory.java:79)
        at org.apache.geode.internal.net.SocketCreatorFactory.getOrCreateSocketCreatorForSSLEnabledComponent(SocketCreatorFactory.java:95)
        at org.apache.geode.internal.net.SocketCreatorFactory.getSocketCreatorForComponent(SocketCreatorFactory.java:70)
        at org.apache.geode.distributed.internal.tcpserver.TcpClient.<init>(TcpClient.java:74)
        at org.apache.geode.cache.client.internal.AutoConnectionSourceImpl.<init>(AutoConnectionSourceImpl.java:118)
        at org.apache.geode.cache.client.internal.PoolImpl.getSourceImpl(PoolImpl.java:651)
        at org.apache.geode.cache.client.internal.PoolImpl.<init>(PoolImpl.java:248)
        at org.apache.geode.cache.client.internal.PoolImpl.create(PoolImpl.java:157)
        at org.apache.geode.internal.cache.PoolFactoryImpl.create(PoolFactoryImpl.java:338)
        at org.apache.geode.internal.cache.GemFireCacheImpl.determineDefaultPool(GemFireCacheImpl.java:2919)
        at org.apache.geode.internal.cache.GemFireCacheImpl.initializeDeclarativeCache(GemFireCacheImpl.java:1394)
        at org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1219)
        at org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:768)
        at org.apache.geode.internal.cache.GemFireCacheImpl.createClient(GemFireCacheImpl.java:740)
        at org.apache.geode.cache.client.ClientCacheFactory.basicCreate(ClientCacheFactory.java:264)
        at org.apache.geode.cache.client.ClientCacheFactory.create(ClientCacheFactory.java:213)
        at org.apache.geode.examples.clientSecurity.Example.<init>(Example.java:70)
        at org.apache.geode.examples.clientSecurity.Example.adminUserCanPutAndGetEverywhere(Example.java:86)
        at org.apache.geode.examples.clientSecurity.Example.main(Example.java:78)
Caused by: java.lang.ClassNotFoundException: org.springframework.shell.core.JLineShell
        at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 38 more
{noformat}

As you can see in below code *GfeConsoleReader* is initialized and is at the beginning of the function which causes the above exception. While this should be a dependency only for gfsh (to read inputs from the interactive shell) and not for non-interactive clients (consider a default).

{code}
private KeyManager[] getKeyManagers() throws KeyStoreException, IOException,
      NoSuchAlgorithmException, CertificateException, UnrecoverableKeyException {
    GfeConsoleReader consoleReader = GfeConsoleReaderFactory.getDefaultConsoleReader();

    if (sslConfig.getKeystore() == null) {
      return null;
    }

    KeyManager[] keyManagers = null;
    String keyStoreType = sslConfig.getKeystoreType();
    if (StringUtils.isEmpty(keyStoreType)) {
      // read from console, default on empty
      if (consoleReader.isSupported()) {
        keyStoreType =
            consoleReader.readLine("Please enter the keyStoreType (javax.net.ssl.keyStoreType) : ");
      } else {
        keyStoreType = KeyStore.getDefaultType();
      }
    }
{code}

A proposed fix is to avoid creating the `GfeConsoleReader` upfront and only do when it is required (for interactive shells).


> Reducing the scope of JLineShell dependency for non-interactive clients.
> ------------------------------------------------------------------------
>
>                 Key: GEODE-4291
>                 URL: https://issues.apache.org/jira/browse/GEODE-4291
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh, security
>            Reporter: Sai Boorlagadda
>            Assignee: Sai Boorlagadda
>
> When using *SSL*, clients have to include *org.springframework.shell:spring-shell* dependency as geode expects the class on the class path and fails with below exception:
> {noformat}
> [error 2018/01/12 09:56:57.829 PST <main> tid=0x1] java.lang.NoClassDefFoundError: org/springframework/shell/core/JLineShell
> Exception in thread "main" java.lang.NoClassDefFoundError: org/springframework/shell/core/JLineShell
>         at java.lang.ClassLoader.defineClass1(Native Method)
>         at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
>         at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
>         at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
>         at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
>         at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
>         at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
>         at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>         at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
>         at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>         at org.apache.geode.internal.GfeConsoleReaderFactory.createConsoleReader(GfeConsoleReaderFactory.java:42)
>         at org.apache.geode.internal.GfeConsoleReaderFactory.<clinit>(GfeConsoleReaderFactory.java:33)
>         at org.apache.geode.internal.net.SocketCreator.getKeyManagers(SocketCreator.java:537)
>         at org.apache.geode.internal.net.SocketCreator.createAndConfigureSSLContext(SocketCreator.java:395)
>         at org.apache.geode.internal.net.SocketCreator.initialize(SocketCreator.java:352)
>         at org.apache.geode.internal.net.SocketCreator.<init>(SocketCreator.java:269)
>         at org.apache.geode.internal.net.SocketCreatorFactory.createSSLSocketCreator(SocketCreatorFactory.java:105)
>         at org.apache.geode.internal.net.SocketCreatorFactory.getSSLSocketCreator(SocketCreatorFactory.java:79)
>         at org.apache.geode.internal.net.SocketCreatorFactory.getOrCreateSocketCreatorForSSLEnabledComponent(SocketCreatorFactory.java:95)
>         at org.apache.geode.internal.net.SocketCreatorFactory.getSocketCreatorForComponent(SocketCreatorFactory.java:70)
>         at org.apache.geode.distributed.internal.tcpserver.TcpClient.<init>(TcpClient.java:74)
>         at org.apache.geode.cache.client.internal.AutoConnectionSourceImpl.<init>(AutoConnectionSourceImpl.java:118)
>         at org.apache.geode.cache.client.internal.PoolImpl.getSourceImpl(PoolImpl.java:651)
>         at org.apache.geode.cache.client.internal.PoolImpl.<init>(PoolImpl.java:248)
>         at org.apache.geode.cache.client.internal.PoolImpl.create(PoolImpl.java:157)
>         at org.apache.geode.internal.cache.PoolFactoryImpl.create(PoolFactoryImpl.java:338)
>         at org.apache.geode.internal.cache.GemFireCacheImpl.determineDefaultPool(GemFireCacheImpl.java:2919)
>         at org.apache.geode.internal.cache.GemFireCacheImpl.initializeDeclarativeCache(GemFireCacheImpl.java:1394)
>         at org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1219)
>         at org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:768)
>         at org.apache.geode.internal.cache.GemFireCacheImpl.createClient(GemFireCacheImpl.java:740)
>         at org.apache.geode.cache.client.ClientCacheFactory.basicCreate(ClientCacheFactory.java:264)
>         at org.apache.geode.cache.client.ClientCacheFactory.create(ClientCacheFactory.java:213)
>         at org.apache.geode.examples.clientSecurity.Example.<init>(Example.java:70)
>         at org.apache.geode.examples.clientSecurity.Example.adminUserCanPutAndGetEverywhere(Example.java:86)
>         at org.apache.geode.examples.clientSecurity.Example.main(Example.java:78)
> Caused by: java.lang.ClassNotFoundException: org.springframework.shell.core.JLineShell
>         at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
>         at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>         at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
>         at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>         ... 38 more
> {noformat}
> As you can see in below code *GfeConsoleReader* is initialized and is at the beginning of the function which causes the above exception. While this should be a dependency only for gfsh (to read inputs from the interactive shell) and not for non-interactive clients (consider a default).
> {code}
> private KeyManager[] getKeyManagers() throws KeyStoreException, IOException,
>       NoSuchAlgorithmException, CertificateException, UnrecoverableKeyException {
>     GfeConsoleReader consoleReader = GfeConsoleReaderFactory.getDefaultConsoleReader();
>     if (sslConfig.getKeystore() == null) {
>       return null;
>     }
>     KeyManager[] keyManagers = null;
>     String keyStoreType = sslConfig.getKeystoreType();
>     if (StringUtils.isEmpty(keyStoreType)) {
>       // read from console, default on empty
>       if (consoleReader.isSupported()) {
>         keyStoreType =
>             consoleReader.readLine("Please enter the keyStoreType (javax.net.ssl.keyStoreType) : ");
>       } else {
>         keyStoreType = KeyStore.getDefaultType();
>       }
>     }
> {code}
> A proposed fix is to avoid creating the `GfeConsoleReader` upfront and only do when it is required (for interactive shells).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)