From issues-return-28661-archive-asf-public=cust-asf.ponee.io@geode.apache.org Wed Jan 10 21:45:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E5FDC18072F for ; Wed, 10 Jan 2018 21:45:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D61EA160C40; Wed, 10 Jan 2018 20:45:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 318CE160C2E for ; Wed, 10 Jan 2018 21:45:08 +0100 (CET) Received: (qmail 9767 invoked by uid 500); 10 Jan 2018 20:45:07 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 9614 invoked by uid 99); 10 Jan 2018 20:45:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 20:45:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B4B1F1808DB for ; Wed, 10 Jan 2018 20:45:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -107.911 X-Spam-Level: X-Spam-Status: No, score=-107.911 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Cpx8IcDuXjQV for ; Wed, 10 Jan 2018 20:45:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 537FA5F635 for ; Wed, 10 Jan 2018 20:45:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 90760E25CB for ; Wed, 10 Jan 2018 20:45:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id E9E9D274E0 for ; Wed, 10 Jan 2018 20:45:01 +0000 (UTC) Date: Wed, 10 Jan 2018 20:45:01 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-4269) Remove DataInput::readObject(bool) which auto casts with boolean flag. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321068#comment-16321068 ] ASF subversion and git services commented on GEODE-4269: -------------------------------------------------------- Commit 6da068f8386aaa50276785a122524523a00814bb in geode-native's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=6da068f ] GEODE-4269: Replaces magic casting readObject. (#184) > Remove DataInput::readObject(bool) which auto casts with boolean flag. > ---------------------------------------------------------------------- > > Key: GEODE-4269 > URL: https://issues.apache.org/jira/browse/GEODE-4269 > Project: Geode > Issue Type: Improvement > Components: native client > Reporter: Jacob S. Barrett > Assignee: Jacob S. Barrett > > Remove DataInput::readObject(bool) which auto casts with boolean flag. The ambiguity of the casting could lead to bad programming habits. Return the original object and let the caller cast using the appropriate methods. -- This message was sent by Atlassian JIRA (v6.4.14#64029)