From issues-return-29723-archive-asf-public=cust-asf.ponee.io@geode.apache.org Fri Jan 26 18:45:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id AEF7A180657 for ; Fri, 26 Jan 2018 18:45:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9F0EF160C50; Fri, 26 Jan 2018 17:45:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E6E2C160C2E for ; Fri, 26 Jan 2018 18:45:07 +0100 (CET) Received: (qmail 16885 invoked by uid 500); 26 Jan 2018 17:45:07 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 16876 invoked by uid 99); 26 Jan 2018 17:45:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jan 2018 17:45:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A5BD31815FE for ; Fri, 26 Jan 2018 17:45:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 1E4FwrgkoWy9 for ; Fri, 26 Jan 2018 17:45:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D79F15FBBC for ; Fri, 26 Jan 2018 17:45:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 19F7AE0161 for ; Fri, 26 Jan 2018 17:45:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5009824106 for ; Fri, 26 Jan 2018 17:45:00 +0000 (UTC) Date: Fri, 26 Jan 2018 17:45:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-4142) When processing the beforeCompletion message, transaction should check if the transaction has been completed already MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341338#comment-16341338 ] ASF subversion and git services commented on GEODE-4142: -------------------------------------------------------- Commit 47df59a967bbb30121ea6e996f124cfb8529b098 in geode's branch refs/heads/develop from [~eshu] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=47df59a ] GEODE-4142: save commit message for failover after jta commit (#1324) * GEODE-4142: save commit message for failover after jta commit. check if the jta has completed before retrying the beforeCompeltion and afterCompletion in failover cases. > When processing the beforeCompletion message, transaction should check if the transaction has been completed already > -------------------------------------------------------------------------------------------------------------------- > > Key: GEODE-4142 > URL: https://issues.apache.org/jira/browse/GEODE-4142 > Project: Geode > Issue Type: Bug > Components: transactions > Reporter: Eric Shu > Assignee: Eric Shu > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The following NPE could occur if the JTA has been committed but client connection was lost. The client retries the afterCompletion on another node. Needs to check if the JTA has been completed/committed already. > {noformat} > java.lang.NullPointerException > at org.apache.geode.internal.cache.JtaBeforeCompletionMessage.operateOnTx(JtaBeforeCompletionMessage.java:66) > at org.apache.geode.internal.cache.TXMessage.process(TXMessage.java:88) > at org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:374) > at org.apache.geode.distributed.internal.DistributionMessage.schedule(DistributionMessage.java:432) > at org.apache.geode.distributed.internal.DistributionManager.scheduleIncomingMessage(DistributionManager.java:3554) > at org.apache.geode.distributed.internal.DistributionManager.handleIncomingDMsg(DistributionManager.java:3188) > at org.apache.geode.distributed.internal.DistributionManager$MyListener.messageReceived(DistributionManager.java:4363) > at org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.dispatchMessage(GMSMembershipManager.java:1127) > at org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.handleOrDeferMessage(GMSMembershipManager.java:1045) > at org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager$MyDCReceiver.messageReceived(GMSMembershipManager.java:408) > at org.apache.geode.distributed.internal.direct.DirectChannel.receive(DirectChannel.java:715) > at org.apache.geode.internal.tcp.TCPConduit.messageReceived(TCPConduit.java:875) > at org.apache.geode.internal.tcp.Connection.dispatchMessage(Connection.java:3967) > at org.apache.geode.internal.tcp.Connection.processNIOBuffer(Connection.java:3553) > at org.apache.geode.internal.tcp.Connection.runNioReader(Connection.java:1829) > at org.apache.geode.internal.tcp.Connection.run(Connection.java:1690) > at java.lang.Thread.run(Thread.java:745) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)