From issues-return-29791-archive-asf-public=cust-asf.ponee.io@geode.apache.org Mon Jan 29 15:12:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 426F4180654 for ; Mon, 29 Jan 2018 15:12:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 32CEF160C3F; Mon, 29 Jan 2018 14:12:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7A3DB160C31 for ; Mon, 29 Jan 2018 15:12:05 +0100 (CET) Received: (qmail 76850 invoked by uid 500); 29 Jan 2018 14:12:04 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 76841 invoked by uid 99); 29 Jan 2018 14:12:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jan 2018 14:12:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 402D1C247F for ; Mon, 29 Jan 2018 14:12:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id gg9hT6eSw_1w for ; Mon, 29 Jan 2018 14:12:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 121C15FC0C for ; Mon, 29 Jan 2018 14:12:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 27C7FE01DB for ; Mon, 29 Jan 2018 14:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9F8E72410C for ; Mon, 29 Jan 2018 14:12:00 +0000 (UTC) Date: Mon, 29 Jan 2018 14:12:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-4139) Improve gradle task checkMissedTest to inspect annotations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-4139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343386#comment-16343386 ] ASF subversion and git services commented on GEODE-4139: -------------------------------------------------------- Commit 819599ba26944353ed72ac312f3b11e72e2ce425 in geode's branch refs/heads/develop from [~jens.deppe] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=819599b ] GEODE-4139: Add javac processor to ensure correct RunWith options are enabled for parameterized tests (#1318) - This ensures that if @RunWith(Parameterized.class) is specified for a test class, then @Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class) is also specified for that class. Without that, the tests are not correctly run as the presence of @Category breaks the parameterization. > Improve gradle task checkMissedTest to inspect annotations > ---------------------------------------------------------- > > Key: GEODE-4139 > URL: https://issues.apache.org/jira/browse/GEODE-4139 > Project: Geode > Issue Type: Sub-task > Components: build, management, tests > Reporter: Patrick Rhomberg > Assignee: Jens Deppe > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > To avoid repetition of this mistake, a safeguard should be in place to require the correct runner wherever the corresponding {{@RunWith}} appears. -- This message was sent by Atlassian JIRA (v7.6.3#76005)