geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-4307) Remove static calls to GemFireCacheImpl.getForPdx
Date Mon, 22 Jan 2018 22:34:00 GMT


ASF subversion and git services commented on GEODE-4307:

Commit b1cb0e3956857aae3552bd79d80da7494402e707 in geode's branch refs/heads/feature/GEODE-4142
from Dan Smith
[;h=b1cb0e3 ]

GEODE-4307: Removing some static calls to GemFireCacheImpl.getForPDX

Removing the easier static calls to getForPdx.

This closes #1299

> Remove static calls to GemFireCacheImpl.getForPdx
> -------------------------------------------------
>                 Key: GEODE-4307
>                 URL:
>             Project: Geode
>          Issue Type: Sub-task
>          Components: serialization
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>            Priority: Major
>              Labels: pull-request-available
> GemFireCacheImpl actually has *two* static instance variables - on called instance and
the other called pdxInstance.
> It's bad enough that we have one static instance variable, but this pdxVariable seems
to be a hack to avoid race conditions related to shutting down the cache.
> If the places that need to call getForPdx can just use a cache that they already have
access to, they won't need this hack.

This message was sent by Atlassian JIRA

View raw message