geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cyrille Artho (JIRA)" <>
Subject [jira] [Updated] (GEODE-3584) Refactor ServerLauncher and LocatorLauncher to eliminate code duplication
Date Wed, 10 Jan 2018 03:11:00 GMT


Cyrille Artho updated GEODE-3584:
    Attachment: GEODE-3584-WIP-4

GEODE-3584-WIP-4 adds wrapper methods for chainable calls, so the correct (sub)type is returned.
This is not pretty but eliminates all the typecasts that would otherwise be necessary and
cause too many changes elsewhere. The functionality is still merged into one place, as the
wrappers are just one-liners.

> Refactor ServerLauncher and LocatorLauncher to eliminate code duplication
> -------------------------------------------------------------------------
>                 Key: GEODE-3584
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>    Affects Versions: 1.2.0
>            Reporter: Kenneth Howe
>         Attachments: GEODE-3584-WIP, GEODE-3584-WIP-2, GEODE-3584-WIP-3, GEODE-3584-WIP-4
> There is some duplication of code in the Launcher classes that can be eliminated. Both
classes have methods such as getBindAddress (called getServerBindAddress in ServerLauncher)
that could be hoisted into  AbstractLauncher class that they both extend. The same goes for
the inner State classes of the Launchers; they have methods that could be moved to AbstractLauncher.ServiceState.

This message was sent by Atlassian JIRA

View raw message