geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-4084) rename handshake.proto
Date Tue, 12 Dec 2017 22:31:05 GMT


ASF GitHub Bot commented on GEODE-4084:

bschuchardt opened a new pull request #1155: GEODE-4084 rename handshake.proto
   renamed to protocolVersion
   Thank you for submitting a contribution to Apache Geode.
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   - [x] Has your PR been rebased against the latest commit within the target branch (typically
   - [x] Is your initial contribution a single, squashed commit?
   - [x] Does `gradlew build` run cleanly?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to
   @WireBaron @upthewaterspout @galen-pivotal @PivotalSarge 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> rename handshake.proto
> ----------------------
>                 Key: GEODE-4084
>                 URL:
>             Project: Geode
>          Issue Type: Task
>          Components: client/server
>            Reporter: Bruce Schuchardt
>            Assignee: Bruce Schuchardt
>             Fix For: 1.4.0
> We envision having another handshake between client & server in the future.  Since
the current Handshake is going to remain fixed in content for the foreseeable future we should
rename it to something more like "NewConnectionVersion" or something.  Then we can introduce
a Handshake with more information exchange in the future.

This message was sent by Atlassian JIRA

View raw message