geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-4052) Expand GfshExitCodeStatusCommandTest into multiple classes for more meaningful failure reporting
Date Wed, 06 Dec 2017 00:48:32 GMT

    [ https://issues.apache.org/jira/browse/GEODE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279460#comment-16279460
] 

ASF GitHub Bot commented on GEODE-4052:
---------------------------------------

PurelyApplied opened a new pull request #1125: GEODE-4052: Expand GfshExitCodeStatusCommandsTest
to multiple...
URL: https://github.com/apache/geode/pull/1125
 
 
   ... acceptance tests for better cohesion and failure reporting.
   
   ---
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Expand GfshExitCodeStatusCommandTest into multiple classes for more meaningful failure
reporting
> ------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-4052
>                 URL: https://issues.apache.org/jira/browse/GEODE-4052
>             Project: Geode
>          Issue Type: Test
>          Components: gfsh, tests
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>
> Occasionally, the majority of this class's tests will fail due to being unable to start
the cluster.  Such a failure is beyond the scope of the test and should be reported quickly.
> This class should be divided into two classes, one containing those tests that require
the cluster's server to be running and one that does not.  The cluster start-up in both cases
should be delegated to a {{@BeforeClass}} method so that failure occurs as the class level
and is quickly recognizable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message