geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-4049) Command that executes function on multiple members should report the status of execution on each member
Date Tue, 05 Dec 2017 15:37:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278737#comment-16278737
] 

ASF GitHub Bot commented on GEODE-4049:
---------------------------------------

pdxrunner commented on a change in pull request #1118: GEODE-4049: refactor CreateRegionCommand
and DestoryRegionCommand status
URL: https://github.com/apache/geode/pull/1118#discussion_r154983359
 
 

 ##########
 File path: geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java
 ##########
 @@ -77,4 +80,22 @@
   public boolean isPossibleDuplicate();
 
   public Cache getCache();
+
+  /**
+   * a convenience method to get the name of the member this function executes on. call this
+   * function once in your function execution to avoid performance issues.
+   *
+   * @return member name or id if name is blank
+   */
+  public default String getMemberName() {
 
 Review comment:
   May feel like a utility method, but I think it's appropriate. This same bit of code is
exists  in other *Function classes so it makes sense to put the implementation here. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Command that executes function on multiple members should report the status of execution
on each member
> -------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-4049
>                 URL: https://issues.apache.org/jira/browse/GEODE-4049
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Jinmei Liao
>
> "destroy region", even though executes function on multiple members, do not report the
result as tabular results. Need to change that.
> The tabular results of these commands should be successful if at least one member executes
successfully. Cluster config should be updated if one function gets executed successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message