geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-4033) TxFailover doesn't throw exception when tx state is not found on the server
Date Fri, 01 Dec 2017 21:19:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275000#comment-16275000
] 

ASF GitHub Bot commented on GEODE-4033:
---------------------------------------

nreich commented on a change in pull request #1115: GEODE-4033: Exception is thrown when Tx
Id is not found on server dur…
URL: https://github.com/apache/geode/pull/1115#discussion_r154450693
 
 

 ##########
 File path: geode-core/src/main/java/org/apache/geode/cache/client/internal/OpExecutorImpl.java
 ##########
 @@ -251,21 +251,8 @@ private Object executeWithServerAffinity(ServerLocation loc, Op op)
{
     int transactionId = absOp.getMessage().getTransactionId();
     // for CommitOp we do not have transactionId in AbstractOp
     // so set it explicitly for TXFailoverOp
-    try {
 
 Review comment:
   Is the goal here to get rid of the retry attempt entirely? Does it inherently lead to unexpected
behavior and should have never been done in the first case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> TxFailover doesn't throw exception when tx state is not found on the server
> ---------------------------------------------------------------------------
>
>                 Key: GEODE-4033
>                 URL: https://issues.apache.org/jira/browse/GEODE-4033
>             Project: Geode
>          Issue Type: Bug
>          Components: transactions
>            Reporter: Anilkumar Gingade
>            Assignee: Anilkumar Gingade
>
> When a client transaction gets an exception due to connection failure; it tries to execute
the transaction on other available server. This failover transaction is processed, if the
tx.state is available on any of the servers; if not an exception thrown back to the client.

> Currently the client catches this exception and tries to re-create the exception instead
of returning back to the application. This could cause multiple transaction state to be created
for the same transaction id on the cluster (if the first attempt to the server is still in
process), causing unexpected behavior.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message