geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3955) The gfsh 'describe region' command doesn't include asyncEventQueueIds or gatewaySenderIds
Date Tue, 05 Dec 2017 17:46:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278935#comment-16278935
] 

ASF GitHub Bot commented on GEODE-3955:
---------------------------------------

PurelyApplied commented on a change in pull request #1099: GEODE-3955: Add AEQ and Gateway
Sender information to 'describe region' output.
URL: https://github.com/apache/geode/pull/1099#discussion_r155023687
 
 

 ##########
 File path: geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/RegionAttributesInfo.java
 ##########
 @@ -42,11 +42,8 @@
 
 
 public class RegionAttributesInfo implements Serializable {
-  /**
-   *
-   */
-  private static final long serialVersionUID = 1L;
 
+  private static final long serialVersionUID = 336184564012988487L;
 
 Review comment:
   I believe it's just a convention.  It's not mentioned in any of the Google Java Style Guide
that we've adopted as our own.
   
   It needs to be changed to correctly deserialize, but I think you're right -- it could be
changed to any not-the-previous-value-`1` and be valid.
   
   Looking around online, there doesn't seem to be any consensus on increment vs rehash the
value.  The best I could find was that a big, long number catches the eye and reminds future
developers of the importance of considering backwards incompatibility.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> The gfsh 'describe region' command doesn't include asyncEventQueueIds or gatewaySenderIds
> -----------------------------------------------------------------------------------------
>
>                 Key: GEODE-3955
>                 URL: https://issues.apache.org/jira/browse/GEODE-3955
>             Project: Geode
>          Issue Type: Improvement
>          Components: management
>            Reporter: Barry Oglesby
>            Priority: Minor
>             Fix For: 1.4.0
>
>         Attachments: geode-3955.diff
>
>
> The {{constructor}} and {{getNonDefaultAttributes}} methods in {{org.apache.geode.management.internal.cli.domain.RegionAttributesInfo}}
class would have to be modified to include the {{asyncEventQueueIds}} and {{gatewaySenderIds}}.

> I did a quick modification of this class (attached).
> With these changes, 'describe region' looks like:
> {noformat}
> gfsh>describe region --name=/data
> ..........................................................
> Name            : data
> Data Policy     : partition
> Hosting Members : ln-1
> Non-Default Attributes Shared By Hosting Members  
>   Type    |         Name          | Value
> --------- | --------------------- | ---------
> Region    | data-policy           | PARTITION
>           | async-event-queue-ids | db
>           | size                  | 0
>           | gateway-sender-ids    | ny
> Partition | redundant-copies      | 1
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message