geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3869) Refactor eviction code
Date Tue, 12 Dec 2017 02:04:00 GMT


ASF GitHub Bot commented on GEODE-3869:

agingade opened a new pull request #1152: GEODE-3869: Fix early eviction.
   While code review found that the refactoring moved "evictionNode.unsetRecentlyUsed()" to
   "appendEntry()" which gets call by other places (adding entry into the list); this causes
   the recently used entry to be evicted early.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Refactor eviction code
> ----------------------
>                 Key: GEODE-3869
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: eviction
>            Reporter: Kirk Lund
>            Assignee: Darrel Schneider
>             Fix For: 1.4.0
> Refactor eviction:
> * repackage internal.cache.lru as internal.cache.eviction [1]
> * remove collision between interfaces LRUClockNode and RegionEntry [2]
> [1] I want to repackage org.apache.geode.internal.cache.lru as org.apache.geode.internal.cache.eviction
to prepare for renaming LRU classes to be Eviction classes.
> [2] both interfaces define `void setRecentlyUsed();` -- both of which are implemented
by region entries 

This message was sent by Atlassian JIRA

View raw message