geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-2668) Add gfsh command to destroy gateway receiver
Date Wed, 06 Dec 2017 19:08:01 GMT


ASF GitHub Bot commented on GEODE-2668:

PurelyApplied commented on a change in pull request #1127:  GEODE-2668: build tabular command
result from a list of function results 

 File path: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/
 @@ -88,7 +88,7 @@ public void oneFunctionReturnsError() throws Exception {
     doReturn(mock(Set.class)).when(command).getMembers(any(), any());
-    parser.executeAndAssertThat(command, "destroy gateway-sender --id=1").statusIsError()
+    parser.executeAndAssertThat(command, "destroy gateway-sender --id=1").statusIsSuccess()
 Review comment:
   I'm confused as to why something displaying `ERROR: result2` is a successful execution.
 I would be more inclined to say that any member error constitutes a command error, rather
than any success constitutes command success.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Add gfsh command to destroy gateway receiver
> --------------------------------------------
>                 Key: GEODE-2668
>                 URL:
>             Project: Geode
>          Issue Type: Sub-task
>          Components: docs, gfsh
>            Reporter: Swapnil Bawaskar
> Currently, there is a {{create gateway-receiver}} command, but no corresponding destroy

This message was sent by Atlassian JIRA

View raw message