geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-2668) Add gfsh command to destroy gateway receiver
Date Wed, 06 Dec 2017 19:08:01 GMT


ASF GitHub Bot commented on GEODE-2668:

PurelyApplied commented on a change in pull request #1127:  GEODE-2668: build tabular command
result from a list of function results 

 File path: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/
 @@ -60,8 +62,9 @@ public Result createGatewaySender(@CliOption(key = {CliStrings.GROUP, CliStrings
= true,
 Review comment:
   While I personally like the readability of the extra spacing in a long list of `CliOption`
arguments, it's counter to all our other `GfshCommand` classes.  Would it be preferable to
expand other commands or to collapse this one?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Add gfsh command to destroy gateway receiver
> --------------------------------------------
>                 Key: GEODE-2668
>                 URL:
>             Project: Geode
>          Issue Type: Sub-task
>          Components: docs, gfsh
>            Reporter: Swapnil Bawaskar
> Currently, there is a {{create gateway-receiver}} command, but no corresponding destroy

This message was sent by Atlassian JIRA

View raw message